◐ Shell
reader mode source ↗
Skip to content

gh-87595: mmap.size() now returns the size on Unix for anonymous memory#24781

Merged
serhiy-storchaka merged 8 commits into
python:mainfrom
ZackerySpytz:bpo-43429-mmap-size-platforms
Sep 2, 2025
Merged

gh-87595: mmap.size() now returns the size on Unix for anonymous memory#24781
serhiy-storchaka merged 8 commits into
python:mainfrom
ZackerySpytz:bpo-43429-mmap-size-platforms

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Mar 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Previously, the size would be returned on Windows and an OSError would
be raised on Unix.

https://bugs.python.org/issue43429

@ZackerySpytz
bpo-43429: mmap.size() now returns the size on Unix for anonymous memory …
c90c396 
Previously, the size would be returned on Windows and an OSError would
be raised on Unix.
@github-actions

github-actions Bot commented Apr 7, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale label Apr 7, 2021
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 5, 2022
furkanonder
furkanonder requested changes May 12, 2023
View reviewed changes

@furkanonder furkanonder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. @ZackerySpytz Could you resolve the conflicts?

@arhadthedev arhadthedev changed the title bpo-43429: mmap.size() now returns the size on Unix for anonymous memory May 12, 2023
@arhadthedev

arhadthedev commented May 12, 2023

Copy link
Copy Markdown
Member

Marking as needs backport to 3.11 because the parent issue is marked as type-bug An unexpected behavior, bug, or error .

@arhadthedev arhadthedev added the needs backport to 3.11 only security fixes label May 12, 2023
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.11 only security fixes labels May 9, 2024
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 25, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 27, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 27, 2025
Closed
@serhiy-storchaka

serhiy-storchaka commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@ZackerySpytz, could you please update your PR to 3.15? It should take into account trackfd, like in #138198.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 2, 2025
Merged
@vstinner

vstinner commented Sep 2, 2025

Copy link
Copy Markdown
Member

I'm not sure that @ZackerySpytz is still active. Maybe a new PR should be written?

Hide details View details @serhiy-storchaka serhiy-storchaka merged commit 32032ee into python:main Sep 2, 2025
45 checks passed
@miss-islington-app

miss-islington-app Bot commented Sep 2, 2025

Copy link
Copy Markdown

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
@ZackerySpytz @serhiy-storchaka @miss-islington
pythongh-87595: Support mmap.size() for anonymous mapping on Unix (py… …
147eb94 
…thonGH-24781)

Previously, the size would be returned on Windows and an OSError would
be raised on Unix.

Also, raise ValueError instead of OSError for trackfd=False.
(cherry picked from commit 32032ee)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
@ZackerySpytz @serhiy-storchaka @miss-islington
pythongh-87595: Support mmap.size() for anonymous mapping on Unix (py… …
8c45634 
…thonGH-24781)

Previously, the size would be returned on Windows and an OSError would
be raised on Unix.

Also, raise ValueError instead of OSError for trackfd=False.
(cherry picked from commit 32032ee)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Sep 2, 2025

Copy link
Copy Markdown

GH-138404 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
@bedevere-app

bedevere-app Bot commented Sep 2, 2025

Copy link
Copy Markdown

GH-138405 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 2, 2025
ZackerySpytz
ZackerySpytz commented Sep 2, 2025
View reviewed changes

@ZackerySpytz ZackerySpytz left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello, @serhiy-storchaka. We must modify some of the changes you have made to this PR.

@AA-Turner

AA-Turner commented Sep 2, 2025

Copy link
Copy Markdown
Member

@ZackerySpytz this has been merged, please would you open a new PR?

@ZackerySpytz

ZackerySpytz commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

I'm well aware that this PR has been merged, thank you very much.

@ZackerySpytz

ZackerySpytz commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka I have created GH-138494.

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@ZackerySpytz @serhiy-storchaka @lkollar
pythongh-87595: Support mmap.size() for anonymous mapping on Unix (py… …
9869e76 
…thonGH-24781)

Previously, the size would be returned on Windows and an OSError would
be raised on Unix.

Also, raise ValueError instead of OSError for trackfd=False.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@furkanonder furkanonder

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.