bpo-43723: deprecate camelCase aliases from threading#25174

JelleZijlstra

The snake_case names have existed since Python 2.6, so there is
no reason to keep the old camelCase names around. One similar
method, threading.Thread.isAlive, was already removed in
Python 3.9 (bpo-37804).

https://bugs.python.org/issue43723

The snake_case names have existed since Python 2.6, so there is no reason to keep the old camelCase names around. One similar method, threading.Thread.isAlive, was already removed in Python 3.9 (bpo-37804).

vstinner

Thank you @JelleZijlstra for all updates. The final merged change provides very good explanation on the rationale and also great guidance to fix affected. It's really important to provide good guidance on deprecations, to make developers' life easier.

Change threading.activeCount to synonym threading.active_count.

Change threading.activeCount to synonym threading.active_count. (cherry picked from commit 56c76df) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Cherry-picked from 9825bdf

terryjreedy

That should have been 'backport', not 'revert' in the titles above. Fixed for 3.8 backport. Sorry for any confusion.

Cherry-picked from 9825bdf

vstinner

Thanks for backports @terryjreedy ;-)

Change threading.activeCount to synonym threading.active_count. (cherry picked from commit 56c76df) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

setDaemon() has been deprecated in favor of setting daemon attribute directly in Python 3.10. See: python/cpython#25174

easy_train.py:316: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead thread.setDaemon(True) camelCase methods in threading were deprecated in: python/cpython#25174

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) (Bitbake rev: ea88be5cb39af86a5bc8a7d151ba65bd12df681f) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) (Bitbake rev: ea88be5cb39af86a5bc8a7d151ba65bd12df681f) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) (Bitbake rev: 17e1b37974ab23a9210a264b0f48dc4812aa75af) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) (Bitbake rev: 323f6ce27a1bfd7159e72f29684674ff495dedee) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Deprecated in Python 3.10: https://docs.python.org/3/whatsnew/3.10.html#deprecated python/cpython#25174 Fixes warnings like: ...bitbake/lib/bb/ui/uievent.py:68: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self.t.setDaemon(True) (Bitbake rev: 17e1b37974ab23a9210a264b0f48dc4812aa75af) Signed-off-by: Tim Orling <tim.orling@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

setDaemon was deprecated in python/cpython#25174 Fixes: ``` >>> test_tls_server("ECDHE-RSA-AES128-SHA", "-tls1") Traceback (most recent call last): File "<input>", line 2, in <module> File "<input>", line 9, in test_tls_server File "/usr/lib64/python3.11/threading.py", line 1240, in setDaemon warnings.warn('setDaemon() is deprecated, set the daemon attribute instead', DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead ```

- Support [deprecation](https://peps.python.org/pep-0632/) of distutils for setuptools > 60. - We can't switch to `packaging.version.parse` because many TK components depend of `distutils.version.LooseVersion`. To handle the distutils deprecation, we're switching to the bundled version living on setuptools >= 60. The deprecation warning is still there, so we're suppressing just this one. - Re-enable commented tests - Support [deprecation](python/cpython#25174) of `isSet()` - Upgrade python-api v3.4.0

This method was deprecated in Python 3.10, set the Thread.daemon attribute directly instead. See: python/cpython#25174

The threading camel case methods were deprecated in [1]. A previous pyserial PR [2] fixed a bunch of these warnings, but missed a few. Fix the remaining setName() DeprecationWarnings by using the appropriate name attribute instead. [1] python/cpython#25174 [2] #643 Signed-off-by: Bastian Krause <bst@pengutronix.de>

The threading camel case methods were deprecated in [1]. A previous pyserial PR [2] fixed a bunch of these warnings, but missed a few. Fix the remaining setName() DeprecationWarnings by using the appropriate name attribute instead. [1] python/cpython#25174 [2] pyserial#643 Signed-off-by: Bastian Krause <bst@pengutronix.de>

bpo-43723: deprecate camelCase aliases from threading …

558e66b

The snake_case names have existed since Python 2.6, so there is no reason to keep the old camelCase names around. One similar method, threading.Thread.isAlive, was already removed in Python 3.9 (bpo-37804).

the-knights-who-say-ni added the CLA signed label Apr 4, 2021

bedevere-bot added the awaiting review label Apr 4, 2021

vstinner reviewed Apr 6, 2021

View reviewed changes

JelleZijlstra added 2 commits April 6, 2021 19:55

don't schedule removal, adjust docs

1af898e

update tests

a76261a

vstinner reviewed Apr 7, 2021

View reviewed changes

JelleZijlstra added 2 commits April 7, 2021 20:45

more doc updates

b32c41e

fix make check

be7c522

vstinner reviewed Apr 8, 2021

View reviewed changes

JelleZijlstra added 2 commits April 8, 2021 17:49

reword more docs

8fac027

fix directives

aeae847

vstinner merged commit 9825bdf into python:master Apr 12, 2021

bedevere-bot removed the awaiting review label Apr 12, 2021

terryjreedy added a commit that referenced this pull request Apr 16, 2021

[3.9] bpo-43723: Revert IDLE doc change (GH-25174) …

56c76df

Change threading.activeCount to synonym threading.active_count.

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Apr 16, 2021

[3.8] bpo-43723: Backport IDLE doc change (pythonGH-25174) …

3a8a897

Cherry-picked from 9825bdf

terryjreedy added a commit that referenced this pull request Apr 16, 2021

[3.8] bpo-43723: Backport IDLE doc change (GH-25174) …

b405647

Cherry-picked from 9825bdf

miss-islington added a commit that referenced this pull request Apr 16, 2021

[3.9] bpo-43723: Revert IDLE doc change (GH-25174) …

582917f

Change threading.activeCount to synonym threading.active_count. (cherry picked from commit 56c76df) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Joilence mentioned this pull request Sep 16, 2022

Set daemon attribute directly plotly/Kaleido#146

Merged

alexcjohnson pushed a commit to plotly/Kaleido that referenced this pull request Sep 23, 2022

Set daemon attribute directly (#146) …

e274c69

setDaemon() has been deprecated in favor of setting daemon attribute directly in Python 3.10. See: python/cpython#25174

Karrenbelt mentioned this pull request Oct 14, 2022

Chore/recover linters valory-xyz/open-aea#371

Merged

10 tasks

jupe mentioned this pull request Oct 17, 2022

use daemon property instead embedded-community/nrf-sniffer-cli#6

Merged

gverm mentioned this pull request Oct 20, 2022

Set thread daemon attribute directly instead of using setDaemon trela-official/rabbitmq-pika-flask#45

Merged

linrock mentioned this pull request Nov 25, 2022

Fix warnings about thread.setDaemon() in python 3.10+ official-stockfish/nnue-pytorch#214

Merged

carlos-villavicencio-adsk mentioned this pull request Sep 19, 2023

SG-32657 Enable support for Python 3.10 in CI shotgunsoftware/tk-core#920

Merged

6 tasks

carlos-villavicencio-adsk mentioned this pull request Sep 25, 2023

SG-32969 Test CI with Python 3.10 shotgunsoftware/tk-framework-shotgunutils#144

Merged

2 tasks

AndyTheFactory mentioned this pull request Oct 24, 2023

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 AndyTheFactory/newspaper4k#513

Closed

Bastian-Krause mentioned this pull request Jan 30, 2024

treewide: fix remaining uses of threading camel case methods pyserial/pyserial#734

Merged

carlsmedstad added a commit to carlsmedstad/pifpaf that referenced this pull request Aug 16, 2024

Replace call to deprecated method Thread.setDaemon() …

6d88c66

This method was deprecated in Python 3.10, set the Thread.daemon attribute directly instead. See: python/cpython#25174

carlsmedstad mentioned this pull request Aug 16, 2024

Replace call to deprecated method Thread.setDaemon() jd/pifpaf#184

Merged

tobias-urdin pushed a commit to jd/pifpaf that referenced this pull request Aug 16, 2024

Replace call to deprecated method Thread.setDaemon() (#184) …

213ca69

This method was deprecated in Python 3.10, set the Thread.daemon attribute directly instead. See: python/cpython#25174

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-43723: deprecate camelCase aliases from threading#25174

bpo-43723: deprecate camelCase aliases from threading#25174
vstinner merged 7 commits into
python:masterfrom
JelleZijlstra:camelthread

JelleZijlstra commented Apr 4, 2021 •

edited by bedevere-bot

Loading

Uh oh!

vstinner commented Apr 12, 2021

Uh oh!

terryjreedy commented Apr 16, 2021

Uh oh!

vstinner commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JelleZijlstra commented Apr 4, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Apr 12, 2021

Uh oh!

terryjreedy commented Apr 16, 2021

Uh oh!

vstinner commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JelleZijlstra commented Apr 4, 2021 •

edited by bedevere-bot

Loading