gh-78997: AttributeError if loading fails in LibraryLoader.__getattr__#25177
gh-78997: AttributeError if loading fails in LibraryLoader.__getattr__#25177FFY00 merged 7 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
Hi @farfella, thanks for this, do you think you could add a brief test to verify the original use case? I'm not an expert, but I would assume |
Sorry, something went wrong.
|
Ah, sorry I was referring to an existing file and meant "test_loading.py", not "test_loader.py", my mistake: cpython/Lib/ctypes/test/test_loading.py Line 26 in 507ed6f |
Sorry, something went wrong.
|
Thanks for your all your help and feedback, @jacobtylerwalls! :) Hoping style-checks passes this time. |
Sorry, something went wrong.
|
Thanks! Fewer lines of code. :) |
Sorry, something went wrong.
eric-wieser
left a comment
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
✅ Deploy Preview for python-cpython-preview canceled.
|
Sorry, something went wrong.
|
@farfella I am now in a position where I can merge this, could you update the PR to resolve the conflicts? |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
Sorry, something went wrong.
|
@farfella, it looks like you just discarded all your changes... |
Sorry, something went wrong.
|
Yeah.... I saw this "Sync fork" button (that is new to me) for my branch on GitHub web UI and clicked it. This is the consequence.... My local copy still has everything. I'll push that up. |
Sorry, something went wrong.
|
Updated PR to resolve conflicts |
Sorry, something went wrong.
|
force-pushing may be the reason for the review-request spamming. Please use simple update merges. |
Sorry, something went wrong.
|
Alright, thank you @farfella for getting this back into shape! Can you just apply the feedback from code-review from @eric-wieser? After that, we can go ahead and merge this 👍 |
Sorry, something went wrong.
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
|
Minor rebase issue in the test file. :) |
Sorry, something went wrong.
edited by terryjreedy
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.