◐ Shell
reader mode source ↗
Skip to content

bpo-41111: Build limited C API without Py_TRACE_REFS macro.#25180

Merged
vstinner merged 2 commits into
python:masterfrom
shihai1991:bpo_41111_2
Apr 6, 2021
Merged

bpo-41111: Build limited C API without Py_TRACE_REFS macro.#25180
vstinner merged 2 commits into
python:masterfrom
shihai1991:bpo_41111_2

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@shihai1991 shihai1991 requested a review from vstinner April 4, 2021 08:31
@vstinner vstinner merged commit 5787ba4 into python:master Apr 6, 2021
@vstinner

vstinner commented Apr 6, 2021

Copy link
Copy Markdown
Member

Thanks, I merged your fix.

Without this fix, xxlimited failed to build on the AMD64 Arch Linux TraceRefs 3.x buildbot. Example:

gcc -pthread -fPIC -Wno-unused-result -Wsign-compare -g -Og -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I./Include/internal -I./Include -I. -I/usr/local/include -I/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Include -I/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build -c /buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Modules/xxlimited_35.c -o build/temp.linux-x86_64-3.10-pydebug/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Modules/xxlimited_35.o
In file included from ./Include/Python.h:87,
                 from /buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Modules/xxlimited_35.c:10:
./Include/object.h:61:4: error: #error Py_LIMITED_API is incompatible with Py_TRACE_REFS
   61 | #  error Py_LIMITED_API is incompatible with Py_TRACE_REFS
      |    ^~~~~

https://buildbot.python.org/all/#/builders/484/builds/525

But it's not treated as an error: the compilation is displayed as a success. Moreover, test_xxlimited is simply skipped if xxlimited is missing.

This change should fix it.

@shihai1991

shihai1991 commented Apr 6, 2021

Copy link
Copy Markdown
Member Author

Thanks Victor for your review & merge :)

@vstinner vstinner mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot