◐ Shell
reader mode source ↗
Skip to content

bpo-42128: Update pattern matching docs to match new PEP changes#25185

Merged
gvanrossum merged 1 commit into
python:masterfrom
Fidget-Spinner:pep634-pythondevupdates
Apr 6, 2021
Merged

bpo-42128: Update pattern matching docs to match new PEP changes#25185
gvanrossum merged 1 commit into
python:masterfrom
Fidget-Spinner:pep634-pythondevupdates

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Apr 4, 2021

Copy link
Copy Markdown
Member

On python-dev, changes to PEP 634 were discussed and proposed, this patch just brings the docs up to speed:

  1. builtin types accept keyword argument patterns
  2. __match_args__ must be a tuple

Ref: https://mail.python.org/archives/list/python-dev@python.org/thread/YYIT3QXMLPNLXQAQ5BCXE4LLJ57EE7JV/

python/peps#1908 and python/peps#1909 needs to be merged before this can be merged.

https://bugs.python.org/issue42128

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

You can un-draft this now!

@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review April 6, 2021 15:11
@gvanrossum gvanrossum merged commit 5143fd1 into python:master Apr 6, 2021
@bedevere-bot

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the pep634-pythondevupdates branch April 6, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants