◐ Shell
reader mode source ↗
Skip to content

bpo-43779: _PyArena_AddPyObject only steals a ref on success#25289

Merged
pablogsal merged 1 commit into
python:masterfrom
erlend-aasland:fix-pyarena-addpyobject-refleaks
Apr 8, 2021
Merged

bpo-43779: _PyArena_AddPyObject only steals a ref on success#25289
pablogsal merged 1 commit into
python:masterfrom
erlend-aasland:fix-pyarena-addpyobject-refleaks

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 8, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Apr 8, 2021

Copy link
Copy Markdown
Contributor Author

skip news

@bedevere-bot bedevere-bot added and removed awaiting review labels Apr 8, 2021
@pablogsal pablogsal merged commit c0e11a3 into python:master Apr 8, 2021
@miss-islington

miss-islington commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c0e11a3ceb9427e09db4224f394c7789bf6deec5 3.9

@pablogsal

pablogsal commented Apr 8, 2021

Copy link
Copy Markdown
Member

@erlend-aasland Could you do the manual backport?

@erlend-aasland

erlend-aasland commented Apr 8, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland Could you do the manual backport?

Sure!

@erlend-aasland erlend-aasland deleted the fix-pyarena-addpyobject-refleaks branch April 8, 2021 23:20
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Apr 8, 2021
[3.9] Fix possible refleak involving _PyArena_AddPyObject (pythonGH-2… …
7430f23 
…5289).

(cherry picked from commit c0e11a3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Apr 8, 2021

Copy link
Copy Markdown

GH-25294 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Apr 9, 2021
@pablogsal
[3.9] bpo-43779: Fix possible refleak involving _PyArena_AddPyObject (G… …
76d270e 
…H-25289). (GH-25294)

* [3.9] Fix possible refleak involving _PyArena_AddPyObject (GH-25289).
(cherry picked from commit c0e11a3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update Parser/pegen/pegen.c

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @pablogsal @bedevere-bot @the-knights-who-say-ni