{{ message }}
bpo-30822: Fix testing of datetime module.#2530
Merged
serhiy-storchaka merged 6 commits intoJul 2, 2017
Merged
Conversation
Contributor
Sorry, something went wrong.
|
@musically-ut, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalkin, @serhiy-storchaka and @birkenfeld to be potential reviewers. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Jul 2, 2017
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 3, 2017
Only C implementation was tested.. (cherry picked from commit 98b6bc3)
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 3, 2017
Only C implementation was tested. (cherry picked from commit 98b6bc3)
vstinner
added a commit
that referenced
this pull request
Jul 5, 2017
vstinner
added a commit
that referenced
this pull request
Jul 5, 2017
* Revert "bpo-30854: Fix compile error when --without-threads (#2581)" This reverts commit 0c31163. * Revert "NEWS for 30777 (#2576)" This reverts commit aaa917f. * Revert "bpo-21624: IDLE -- minor htest fixes (#2575)" This reverts commit 2000150. * Revert "bpo-30777: IDLE: configdialog - add docstrings and improve comments (#2440)" This reverts commit 7eb5883. * Revert "bpo-30319: socket.close() now ignores ECONNRESET (#2565)" This reverts commit 67e1478. * Revert "bpo-30789: Use a single memory block for co_extra. (#2555)" This reverts commit 378ebb6. * Revert "bpo-30845: Enhance test_concurrent_futures cleanup (#2564)" This reverts commit 3df9dec. * Revert "bpo-29293: multiprocessing.Condition.notify() lacks parameter `n` (#2480)" This reverts commit 4835041. * Revert "Remove outdated FOX from GUI FAQ (GH-2538)" This reverts commit d3ed287. * Revert "bpo-6691: Pyclbr now reports nested classes and functions. (#2503)" This reverts commit 246ff3b. * Revert "bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORDS and make (#1955)" This reverts commit 6969eaf. * Revert "bpo-30832: Remove own implementation for thread-local storage (#2537)" This reverts commit aa0aa04. * Revert "bpo-30764: Fix regrtest --fail-env-changed --forever (#2536)" This reverts commit 5e87592. * Revert "bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (#2534)" This reverts commit 34b5487. * Revert "bpo-30822: Fix testing of datetime module. (#2530)" This reverts commit 98b6bc3.
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 20, 2017
Only C implementation was tested.
vstinner
pushed a commit
that referenced
this pull request
Jul 21, 2017
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 22, 2017
…honGH-2783) Only C implementation was tested.. (cherry picked from commit 287c559)
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 22, 2017
…honGH-2783) Only C implementation was tested. (cherry picked from commit 287c559)
musically-ut
added a commit
to musically-ut/cpython
that referenced
this pull request
Jul 22, 2017
…honGH-2783) Only C implementation was tested.. (cherry picked from commit 287c559)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
On
masterand in versions 3.6 and 3.5, there is a bug in how certain tests are executed differently for the C extension and python extension. The execution of the tests (indatetimetester.py) depends on the following condition (or the negation thereof):The
cls.__name__is modified in thetest_datetime.pyto be:However,
str(self)to derives the class name fromcls.__qualname__and notcls.__name__. This meant that_Fastwas never instr(self)and, hence, some of the tests were being unnecessarily skipped (notablytest_name_cleanup, which was failing).This PR fixes the problem by clearly setting a string value on the class (
_test_type) and then conditioning tests based on that value. Also, instead of editing the__name__of the class, the__qualname__is edited so that the tests show the correct variant of the test being run in verbose mode, which helps reduce confusion [1].Also, on
masterand in version 3.6, there was another bug which prevented all tests from running because of an accidental resetting of the global variabletest_classesinside a loop. That is fixed in a separate commit.#1493 depends on this PR.
[1]: Example on core-mentorship archives (accessible only to members).