◐ Shell
reader mode source ↗
Skip to content

bpo-43788: Generate version specific _ssl_data.h#25300

Merged
miss-islington merged 2 commits into
python:masterfrom
tiran:ssl_data
Apr 9, 2021
Merged

bpo-43788: Generate version specific _ssl_data.h#25300
miss-islington merged 2 commits into
python:masterfrom
tiran:ssl_data

Conversation

@tiran

@tiran tiran commented Apr 9, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue43788

Automerge-Triggered-By: GH:tiran

@tiran tiran requested a review from benjaminp April 9, 2021 10:12
@stefanrad25

This comment has been minimized.

Sign in to view
@stefanrad25

This comment has been minimized.

Sign in to view
@tiran
bpo-43788: Generate version specific _ssl_data.h …
38a3124 
Signed-off-by: Christian Heimes <christian@python.org>
benjaminp
benjaminp approved these changes Apr 9, 2021
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

this is definitely a lot better than parsing the headers

@tiran

tiran commented Apr 9, 2021

Copy link
Copy Markdown
Member Author

Thanks for the wording fix!

@miss-islington

miss-islington commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 150af75 into python:master Apr 9, 2021
@miss-islington

miss-islington commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 150af7543214e1541fa582374502ac1cd70e8eb4 3.9

@miss-islington miss-islington self-assigned this Apr 9, 2021
@miss-islington

miss-islington commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 150af7543214e1541fa582374502ac1cd70e8eb4 3.8

tiran added a commit to tiran/cpython that referenced this pull request Apr 9, 2021
@tiran
[3.9] bpo-43788: Generate version specific _ssl_data.h (pythonGH-25300) …
cd57304 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

bedevere-bot commented Apr 9, 2021

Copy link
Copy Markdown

GH-25310 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

bedevere-bot commented Apr 9, 2021

Copy link
Copy Markdown

GH-25311 is a backport of this pull request to the 3.8 branch.

tiran added a commit that referenced this pull request Apr 9, 2021
@tiran
[3.9] bpo-43788: Generate version specific _ssl_data.h (GH-25300) (GH… …
299ae9c 
…-25310)

(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this pull request Apr 9, 2021
@tiran
[3.8] bpo-43788: Generate version specific _ssl_data.h (GH-25300) (GH… …
70f2ca7 
…-25311)

(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this pull request Jul 1, 2022
@tiran
bpo-43788: Generate version specific _ssl_data.h (pythonGH-25300)
69105fa
@davidben davidben mentioned this pull request Dec 6, 2022
Closed
davidben added a commit to davidben/cpython that referenced this pull request Dec 6, 2022
@davidben
pythongh-100062: Remove error code tables from _ssl and err_names_to_… …
12b9314 
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
@davidben davidben mentioned this pull request Dec 6, 2022
Merged
davidben added a commit to davidben/cpython that referenced this pull request Dec 6, 2022
@davidben
pythongh-100062: remove error code tables from _ssl and err_names_to_… …
319487e 
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
zooba pushed a commit that referenced this pull request Apr 3, 2023
@davidben
gh-100062: Remove error code tables from _ssl and err_names_to_codes (G… …
02f9920 
…H-100063)

Prior to #25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
@davidben @gaogaotiantian
pythongh-100062: Remove error code tables from _ssl and err_names_to_… …
2fb929d 
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@davidben @warsaw
pythongh-100062: Remove error code tables from _ssl and err_names_to_… …
d5ae21d 
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
stratakis pushed a commit to stratakis/cpython that referenced this pull request Mar 11, 2024
@tiran @stratakis
bpo-43788: Generate version specific _ssl_data.h (pythonGH-25300) (py… …
e440e16 
…thonGH-25311)

(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <christian@python.org>
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull request Apr 2, 2024
@tiran @mcepl
bpo-43788: Generate version specific _ssl_data.h (pythonGH-25300) (py… …
170af1d 
…thonGH-25311)

(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran @stefanrad25 @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni