◐ Shell
reader mode source ↗
Skip to content

bpo-42248: [Enum] ensure exceptions raised in _missing_ are released#25350

Merged
ethanfurman merged 1 commit into
python:masterfrom
ethanfurman:enum-issue42248
Apr 12, 2021
Merged

bpo-42248: [Enum] ensure exceptions raised in _missing_ are released#25350
ethanfurman merged 1 commit into
python:masterfrom
ethanfurman:enum-issue42248

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 12, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@ethanfurman ethanfurman changed the title bpo-42248: [Enum] ensure exceptions raised in _missing__ are released Apr 12, 2021
@ethanfurman ethanfurman merged commit 8c14f5a into python:master Apr 12, 2021
@miss-islington

miss-islington commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8c14f5a787b21d5a1eae5d5ee981431d1c0e055f 3.8

@miss-islington

miss-islington commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Sorry @ethanfurman, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8c14f5a787b21d5a1eae5d5ee981431d1c0e055f 3.9

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 12, 2021
@ethanfurman
[3.8] bpo-42248: [Enum] ensure exceptions raised in _missing_ are… …
0b5d184 
… released (pythonGH-25350).

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 12, 2021
@ethanfurman
[3.9] bpo-42248: [Enum] ensure exceptions raised in _missing_ are… …
abb5398 
… released (pythonGH-25350).

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Apr 12, 2021
@ethanfurman
[3.8] bpo-42248: [Enum] ensure exceptions raised in _missing_ are… …
f396a1a 
… released (GH-25350). (GH-25369)

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Apr 12, 2021
@ethanfurman
[3.9] bpo-42248: [Enum] ensure exceptions raised in _missing_ are… …
6379924 
… released (GH-25350). (GH-25370)

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ethanfurman ethanfurman deleted the enum-issue42248 branch April 15, 2021 14:26
@Mariatta

Mariatta commented Jun 2, 2021

Copy link
Copy Markdown
Member

Does this still need backport to 3.8 and 3.9? If not, please remove the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ethanfurman ethanfurman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ethanfurman @miss-islington @Mariatta @the-knights-who-say-ni @bedevere-bot @ZeroIntensity