{{ message }}
bpo-30832: Remove own implementation for thread-local storage#2537
Merged
vstinner merged 4 commits intoJul 3, 2017
Merged
Conversation
Contributor
Sorry, something went wrong.
CPython has provided the own implementation for thread-local storage (TLS) on Python/thread.c, it's used in the case which a platform has not supplied native TLS. However, currently all supported platforms (NT and pthreads) have provided native TLS and defined the Py_HAVE_NATIVE_TLS macro with unconditional in any case.
vstinner
reviewed
Jul 3, 2017
vstinner
reviewed
Jul 3, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
You can now remove Py_HAVE_NATIVE_TLS define. It's no more used. No?
Sorry, something went wrong.
Member
I don't think so. |
Sorry, something went wrong.
Member
|
Ok. I merged your PR. Let's watch buildbots http://buildbot.python.org/all/waterfall?category=3.x.stable&category=3.x.unstable Maybe I will regret in a few minutes ;-) |
Sorry, something went wrong.
vstinner
added a commit
that referenced
this pull request
Jul 5, 2017
vstinner
added a commit
that referenced
this pull request
Jul 5, 2017
* Revert "bpo-30854: Fix compile error when --without-threads (#2581)" This reverts commit 0c31163. * Revert "NEWS for 30777 (#2576)" This reverts commit aaa917f. * Revert "bpo-21624: IDLE -- minor htest fixes (#2575)" This reverts commit 2000150. * Revert "bpo-30777: IDLE: configdialog - add docstrings and improve comments (#2440)" This reverts commit 7eb5883. * Revert "bpo-30319: socket.close() now ignores ECONNRESET (#2565)" This reverts commit 67e1478. * Revert "bpo-30789: Use a single memory block for co_extra. (#2555)" This reverts commit 378ebb6. * Revert "bpo-30845: Enhance test_concurrent_futures cleanup (#2564)" This reverts commit 3df9dec. * Revert "bpo-29293: multiprocessing.Condition.notify() lacks parameter `n` (#2480)" This reverts commit 4835041. * Revert "Remove outdated FOX from GUI FAQ (GH-2538)" This reverts commit d3ed287. * Revert "bpo-6691: Pyclbr now reports nested classes and functions. (#2503)" This reverts commit 246ff3b. * Revert "bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORDS and make (#1955)" This reverts commit 6969eaf. * Revert "bpo-30832: Remove own implementation for thread-local storage (#2537)" This reverts commit aa0aa04. * Revert "bpo-30764: Fix regrtest --fail-env-changed --forever (#2536)" This reverts commit 5e87592. * Revert "bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (#2534)" This reverts commit 34b5487. * Revert "bpo-30822: Fix testing of datetime module. (#2530)" This reverts commit 98b6bc3.
ma8ma
added a commit
to ma8ma/cpython
that referenced
this pull request
Jul 13, 2017
Resolve conflicts: aa0aa04 bpo-30832: Remove own implementation for thread-local storage (python#2537)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
CPython has provided the own implementation for thread-local storage (TLS) on
Python/thread.c, it's used in the case which a platform has not supplied native TLS. However, currently all supported platforms (NT and pthreads) have provided native TLS and defined thePy_HAVE_NATIVE_TLSmacro with unconditional in any case.Therefore, I'd propose removing outdated code.
http://bugs.python.org/issue30832
Note that the comment for TLS API description is kept up because it isn't in other places. If new Thread Specific Storage API (PEP 539) makes to be in public, this description is removed and probably create description for new API into
Doc/c-api.