◐ Shell
reader mode source ↗
Skip to content

added exception groups#25430

Closed
iritkatriel wants to merge 10 commits into
python:mainfrom
iritkatriel:PEP-654-ExceptionGroup
Closed

added exception groups#25430
iritkatriel wants to merge 10 commits into
python:mainfrom
iritkatriel:PEP-654-ExceptionGroup

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

First step of PEP-654: added Exception Groups (without updating traceback formatting).

@iritkatriel iritkatriel requested a review from a team as a code owner April 16, 2021 00:04
@iritkatriel iritkatriel requested review from 1st1 and gvanrossum April 16, 2021 00:05
gvanrossum
gvanrossum reviewed Apr 16, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Is this what we will merge once the PEP is accepted?

(Note that the master -> main rename will happen at that time too. But supposedly PSs will be automatically adjusted. We’ll see.)

@gvanrossum

gvanrossum commented Apr 16, 2021

Copy link
Copy Markdown
Member

Probably mark as Draft?

@iritkatriel iritkatriel marked this pull request as draft April 16, 2021 07:30
@iritkatriel iritkatriel removed the request for review from a team April 16, 2021 09:43
@iritkatriel iritkatriel force-pushed the PEP-654-ExceptionGroup branch from bbedd10 to 40c3cd0 Compare April 16, 2021 14:03
iritkatriel
iritkatriel commented Apr 16, 2021
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Is this what we will merge once the PEP is accepted?

That's the idea. The branch of the other PR is very old and compile.c/eval.c changed beyond what can be fixed with a rebase. So I started from scratch on a recent cut of master. Marked as draft for now.

@iritkatriel iritkatriel force-pushed the PEP-654-ExceptionGroup branch from 81b6b08 to cecdf32 Compare April 20, 2021 18:42
@gvanrossum

gvanrossum commented May 11, 2021

Copy link
Copy Markdown
Member

You should probably merge this on main.

@iritkatriel iritkatriel force-pushed the PEP-654-ExceptionGroup branch from cecdf32 to 0a9e6b5 Compare May 11, 2021 23:33
@iritkatriel

iritkatriel commented May 11, 2021

Copy link
Copy Markdown
Member Author

I rebased and regenerated Python/importlib_external.h

@github-actions

github-actions Bot commented Jun 12, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 12, 2021
@iritkatriel

iritkatriel commented Sep 26, 2021

Copy link
Copy Markdown
Member Author

Superseded by #28569.

@iritkatriel iritkatriel deleted the PEP-654-ExceptionGroup branch October 18, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@1st1 1st1 Awaiting requested review from 1st1

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon will be requested when the pull request is marked ready for review brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan will be requested when the pull request is marked ready for review ncoghlan is a code owner

@warsaw warsaw warsaw will be requested when the pull request is marked ready for review warsaw is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @gvanrossum @the-knights-who-say-ni @bedevere-bot