◐ Shell
reader mode source ↗
Skip to content

bpo-43926: Cleaner metadata with PEP 566 JSON support.#25565

Merged
jaraco merged 4 commits into
masterfrom
bpo-43926/importlib-metadata-4
May 2, 2021
Merged

bpo-43926: Cleaner metadata with PEP 566 JSON support.#25565
jaraco merged 4 commits into
masterfrom
bpo-43926/importlib-metadata-4

Conversation

@jaraco

@jaraco jaraco commented Apr 23, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@jaraco jaraco force-pushed the bpo-43926/importlib-metadata-4 branch from 927b148 to 2b26539 Compare April 23, 2021 21:49
@jaraco jaraco requested a review from rhettinger as a code owner April 23, 2021 21:49
@jaraco jaraco force-pushed the bpo-43926/importlib-metadata-4 branch from 2b26539 to fc87e54 Compare April 23, 2021 21:50
@jaraco jaraco removed the request for review from rhettinger April 23, 2021 22:29
@jaraco

jaraco commented Apr 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Note, this change includes and should be merged after #25297.

@jaraco jaraco marked this pull request as draft April 23, 2021 22:30
@jaraco jaraco mentioned this pull request Apr 24, 2021
Merged
@jaraco jaraco force-pushed the bpo-43926/importlib-metadata-4 branch from fc87e54 to a0d64c7 Compare April 24, 2021 14:19
@jaraco

jaraco commented Apr 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@warsaw I note also that while we intentionally consolidated importlib.metadata into a single module (#15153), the package has since diversified and the _common module now conflicts with importlib_resources, so I've moved the modules back into a package to avoid the conflict and more clearly separate the concerns.

@jaraco jaraco marked this pull request as ready for review April 24, 2021 14:36
@jaraco jaraco force-pushed the bpo-43926/importlib-metadata-4 branch from 2896650 to a9463bd Compare April 24, 2021 14:56
@jaraco jaraco requested a review from tirkarthi April 30, 2021 20:15
@jaraco

jaraco commented May 2, 2021

Copy link
Copy Markdown
Member Author

In order to ensure this change is included in the 3.10 release, I'm merging now. Happy to troubleshoot or back out specific behaviors as needed.

@jaraco jaraco merged commit 37e0c78 into master May 2, 2021
@jaraco jaraco deleted the bpo-43926/importlib-metadata-4 branch May 2, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaraco @tirkarthi @the-knights-who-say-ni @bedevere-bot