◐ Shell
reader mode source ↗
Skip to content

[3.9] bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553)#25572

Closed
tiran wants to merge 4 commits into
python:3.9from
tiran:backport-c8666cf-3.9
Closed

[3.9] bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553)#25572
tiran wants to merge 4 commits into
python:3.9from
tiran:backport-c8666cf-3.9

Conversation

@tiran

@tiran tiran commented Apr 24, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Revert 73ea546, increase logging, and improve stability of test.

Handle all OSErrors in a single block. OSError also takes care of
SSLError and socket's connection errors.

Partly reverts commit fb7e750. The
threaded connection handler must not raise an unhandled exception..
(cherry picked from commit c8666cf)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue37322

@bedevere-bot bedevere-bot mentioned this pull request Apr 24, 2021
Merged
@tiran tiran force-pushed the backport-c8666cf-3.9 branch from 997d9c4 to 17fd03d Compare April 24, 2021 08:43
@tiran tiran self-assigned this Apr 24, 2021
tiran added 2 commits May 2, 2021 16:45
@tiran
[3.9] bpo-37322: Fix ResourceWarning and exception handling in test (p… …
e08a8bb 
…ythonGH-25553)

Revert 73ea546, increase logging, and improve stability of test.

Handle all OSErrors in a single block. OSError also takes care of
SSLError and socket's connection errors.

Partly reverts commit fb7e750. The
threaded connection handler must not raise an unhandled exception..
(cherry picked from commit c8666cf)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran
bpo-43921: also accept EOF in post-handshake auth test
5d1fb45
@tiran tiran force-pushed the backport-c8666cf-3.9 branch from 17fd03d to 5d1fb45 Compare May 2, 2021 14:46
tiran added 2 commits May 2, 2021 16:50
@tiran
bpo-43921: ignore failing test_wrong_cert_tls13 on Windows (pythonGH-… …
754deac 
…25561)

test_wrong_cert_tls13 sometimes fails on some Windows buildbots. Turn
failing test case into skipped test case until we have more time to
investigate.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
macOS: Try again with increased timeout and backlog of server socket
df15848
@ambv

ambv commented May 3, 2021

Copy link
Copy Markdown
Contributor

There's a few hours left for this to get fixed for inclusion in 3.9.5.

@tiran

tiran commented May 3, 2021

Copy link
Copy Markdown
Member Author

The PR is still unstable. I was not able to figure out the issue over the weekend and I won't have time in the next couple of hours to debug the problem. Let's try it again for 3.9.6.

@github-actions

github-actions Bot commented Jun 3, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 3, 2021
@iritkatriel

iritkatriel commented Apr 11, 2022

Copy link
Copy Markdown
Member

https://bugs.python.org/issue37322 is closed. What is the status of this PR?

@ambv

ambv commented May 16, 2022

Copy link
Copy Markdown
Contributor

We're releasing the last bugfix release of 3.9 today and this PR's been stale for a while. Sadly it's a wontfix now.

@ambv ambv closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiran tiran

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @ambv @iritkatriel @the-knights-who-say-ni @bedevere-bot