◐ Shell
reader mode source ↗
Skip to content

[3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683)#25685

Closed
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-32c5a17-3.9
Closed

[3.9] bpo-43962: Fix _PyInterpreterState_IDIncref() (GH-25683)#25685
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-32c5a17-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue43962

@vstinner @miss-islington
bpo-43962: Fix _PyInterpreterState_IDIncref() (pythonGH-25683) …
6de3080 
_PyInterpreterState_IDIncref() now calls
_PyInterpreterState_IDInitref() and always increments id_refcount.
(cherry picked from commit 32c5a17)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2021
Merged
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Apr 28, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

pablogsal
pablogsal requested changes Apr 28, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please, regenerate the ABI

@bedevere-bot

bedevere-bot commented Apr 28, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ❌ .

@vstinner

vstinner commented Apr 28, 2021

Copy link
Copy Markdown
Member

@pablogsal:

Please, regenerate the ABI

I don't know how to do that: https://bugs.python.org/issue43725#msg392205

@pablogsal

pablogsal commented Apr 28, 2021

Copy link
Copy Markdown
Member

I don't know how to do that: https://bugs.python.org/issue43725#msg392205

Check out the same docker container the CI uses and run the make regen-abidump target.

@github-actions

github-actions Bot commented May 29, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 29, 2021
@vstinner

vstinner commented Oct 15, 2021

Copy link
Copy Markdown
Member

Check out the same docker container the CI uses

I don't know how to do that: https://bugs.python.org/issue43725#msg404019

Maybe I should just abandon this backport.

It's a little bit annoying of not being able to backport a fix because the CI says that it breaks the ABI, whereas the modified function is only part of the internal C API and its name starts with "_Py", so it's a private function.

@vstinner

vstinner commented Jan 23, 2022

Copy link
Copy Markdown
Member

I still don't know how to update the ABI. So I just abandon my bugfix backport, sorry.

@vstinner vstinner closed this Jan 23, 2022
@miss-islington miss-islington deleted the backport-32c5a17-3.9 branch January 23, 2022 01:01
@vstinner vstinner mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal requested changes

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @vstinner @pablogsal @the-knights-who-say-ni