◐ Shell
reader mode source ↗
Skip to content

bpo-43795 - Update Stable ABI dat.#25716

Closed
orsenthil wants to merge 1 commit into
python:masterfrom
orsenthil:abi_fix
Closed

bpo-43795 - Update Stable ABI dat.#25716
orsenthil wants to merge 1 commit into
python:masterfrom
orsenthil:abi_fix

Conversation

@orsenthil

@orsenthil orsenthil commented Apr 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

@orsenthil orsenthil changed the title Update Stable ABI dat. Apr 29, 2021
@orsenthil orsenthil requested a review from encukou April 29, 2021 11:57
@orsenthil orsenthil changed the title bpo-43774 - Update Stable ABI dat. Apr 29, 2021
@orsenthil orsenthil mentioned this pull request Apr 29, 2021
Merged
@orsenthil orsenthil requested a review from scoder April 29, 2021 12:49
@markshannon markshannon mentioned this pull request Apr 29, 2021
Merged
@encukou

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.

@orsenthil

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Updating this PR at the correct location.

@encukou

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

See GH-25720

@orsenthil

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Thank you. This is resolved by #25720

@orsenthil orsenthil closed this Apr 29, 2021
@orsenthil orsenthil deleted the abi_fix branch April 29, 2021 16:04
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@encukou encukou Awaiting requested review from encukou

@scoder scoder

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orsenthil @encukou @scoder @the-knights-who-say-ni @bedevere-bot