◐ Shell
reader mode source ↗
Skip to content

bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag#25743

Merged
vstinner merged 8 commits into
python:masterfrom
erlend-aasland:set-special
Apr 30, 2021
Merged

bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag#25743
vstinner merged 8 commits into
python:masterfrom
erlend-aasland:set-special

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

cc. @vstinner

@erlend-aasland erlend-aasland changed the title bpo-43908: check_set_special_type_attr() now checks for Py_TPFLAGS_IMMUTABLETYPE… Apr 30, 2021
Erlend Egeberg Aasland and others added 2 commits April 30, 2021 12:43
@vstinner
Advertise immutable flag in error message …
392af9c 
Co-authored-by: Victor Stinner <vstinner@python.org>
Address review: improve comments
fd929c0
@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
Member

test_descr does crash on the Windows CI.

@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
Member

I look the liberty of fixing '%R' before I noticed the test_descr crash :-(

@erlend-aasland

erlend-aasland commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

I look the liberty of fixing '%R' before I noticed the test_descr crash :-(

Thanks, Victor! I'm offline for an hour now. Feel free to take care of the fixes and land the PR :) Or I'll look at it later this afternoon.

@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
Member

Thanks, Victor! I'm offline for an hour now. Feel free to take care of the fixes and land the PR :) Or I'll look at it later this afternoon.

No problem, I pushed a fix for test_descr in your PR.

@erlend-aasland

erlend-aasland commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

Thanks!

@vstinner vstinner merged commit 6414138 into python:master Apr 30, 2021
@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
Member

Merged, thanks.

@erlend-aasland erlend-aasland deleted the set-special branch April 30, 2021 13:29
@gvanrossum gvanrossum mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@markshannon markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @vstinner @the-knights-who-say-ni @bedevere-bot