◐ Shell
reader mode source ↗
Skip to content

[3.9] bpo-43882 Remove the newline, and tab early. From query and fragments.#25853

Merged
orsenthil merged 2 commits into
python:3.9from
orsenthil:issue43882_39
May 3, 2021
Merged

[3.9] bpo-43882 Remove the newline, and tab early. From query and fragments.#25853
orsenthil merged 2 commits into
python:3.9from
orsenthil:issue43882_39

Conversation

@orsenthil

@orsenthil orsenthil commented May 3, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Based on the review comment #25726 (review)

Moving the fix for removing newline and tabs early to include both query strings and fragments, (Entire URL).

https://bugs.python.org/issue43882

@orsenthil orsenthil requested a review from gpshead May 3, 2021 14:09
@orsenthil orsenthil changed the title bpo-43882 Remove the newline, and tab early. From query and fragments. May 3, 2021
@bedevere-bot

bedevere-bot commented May 3, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead

gpshead commented May 3, 2021

Copy link
Copy Markdown
Member

fwiw this PR is against 3.9. i assume you'll "backport to main and 3.10" once those aren't actively being release branched and renamed?

@orsenthil

orsenthil commented May 3, 2021

Copy link
Copy Markdown
Member Author

i assume you'll "backport to main and 3.10" once those aren't actively being release branched and renamed?

Yes, exactly. I wanted to time window to be utilized for 3.9 and 3.8.
I will port it to rest of the active branches immediately.

@orsenthil orsenthil merged commit 8a59574 into python:3.9 May 3, 2021
@bedevere-bot

bedevere-bot commented May 3, 2021

Copy link
Copy Markdown

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@gpshead gpshead mentioned this pull request May 3, 2021
Merged
@orsenthil orsenthil mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@adamjstewart adamjstewart adamjstewart left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orsenthil @bedevere-bot @gpshead @adamjstewart @the-knights-who-say-ni