◐ Shell
reader mode source ↗
Skip to content

bpo-25872: Add unit tests for linecache and threading#25913

Merged
iritkatriel merged 21 commits into
python:mainfrom
uniocto:fix-issue-25872
May 18, 2021
Merged

bpo-25872: Add unit tests for linecache and threading#25913
iritkatriel merged 21 commits into
python:mainfrom
uniocto:fix-issue-25872

Conversation

@uniocto

@uniocto uniocto commented May 5, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented May 5, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@uniocto

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 5, 2021
iritkatriel
iritkatriel reviewed May 7, 2021
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you for your first CPython PR! I hope this will be followed by many more.

See a couple of comments below.

@uniocto uniocto force-pushed the fix-issue-25872 branch from 213db0c to 5666a1d Compare May 8, 2021 06:33
iritkatriel
iritkatriel reviewed May 9, 2021
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This is a new thing I wanted to show you - I made a couple of suggested edits. You can click to accept them (and then you don't need to make a new commit). They will be committed, and then you need to pull the changes into your local repo so that you are in sync ("git pull" should do it).

@uniocto @iritkatriel
Update Lib/test/test_linecache.py …
a396fad 
Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@uniocto @iritkatriel
Update Lib/test/test_linecache.py …
833c9b9 
Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@uniocto @iritkatriel
Update Lib/test/test_threading.py …
bcc20ab 
Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
37 hidden items Load more…
@iritkatriel

iritkatriel commented May 17, 2021

Copy link
Copy Markdown
Member

The rebase doesn't look right - the PR should not be showing so many changed files.

@uniocto uniocto force-pushed the fix-issue-25872 branch from 17dfe1c to 78897e7 Compare May 17, 2021 14:39
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2021
@bedevere-bot

bedevere-bot commented May 17, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ac550ef 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2021
@iritkatriel iritkatriel merged commit 115dea9 into python:main May 18, 2021
@miss-islington

miss-islington commented May 18, 2021

Copy link
Copy Markdown
Contributor

Thanks @uniocto for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 18, 2021

Copy link
Copy Markdown
Contributor

Sorry, @uniocto and @iritkatriel, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 115dea9e2602b96b63390f00cc880e90c433efa2 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 18, 2021
@bedevere-bot

bedevere-bot commented May 18, 2021

Copy link
Copy Markdown

GH-26208 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2021
@uniocto @miss-islington
bpo-25872: Add unit tests for linecache and threading (pythonGH-25913) …
bc221b1 
(cherry picked from commit 115dea9)

Co-authored-by: uniocto <serit142sa33go@gmail.com>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request May 18, 2021
@uniocto @iritkatriel
bpo-25872: Add unit tests for linecache and threading (pythonGH-25913) …
c051788 
(cherry picked from commit 115dea9)
@bedevere-bot

bedevere-bot commented May 18, 2021

Copy link
Copy Markdown

GH-26211 is a backport of this pull request to the 3.9 branch.

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request May 18, 2021
@uniocto @iritkatriel
[3.10] bpo-25872: Add unit tests for linecache and threading (pythonG… …
4f32791 
…H-25913)

(cherry picked from commit 115dea9)

Co-authored-by: uniocto <serit142sa33go@gmail.com>
iritkatriel added a commit that referenced this pull request May 18, 2021
@iritkatriel @uniocto
[3.10] bpo-25872: Add unit tests for linecache and threading (GH-25913)… …
373741a 
… (GH-26212)

(cherry picked from commit 115dea9)

Co-authored-by: uniocto <serit142sa33go@gmail.com>
iritkatriel added a commit that referenced this pull request May 18, 2021
@iritkatriel @uniocto
bpo-25872: Add unit tests for linecache and threading (GH-25913) (GH-… …
c05d8a6 
…26211)

(cherry picked from commit 115dea9)

Co-authored-by: uniocto <serit142sa33go@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@iritkatriel iritkatriel

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uniocto @the-knights-who-say-ni @bedevere-bot @iritkatriel @miss-islington