◐ Shell
reader mode source ↗
Skip to content

bpo-40645: Fix reference leak in the _hashopenssl extension#26072

Merged
miss-islington merged 1 commit into
python:mainfrom
encukou:hashlib-refleak
May 12, 2021
Merged

bpo-40645: Fix reference leak in the _hashopenssl extension#26072
miss-islington merged 1 commit into
python:mainfrom
encukou:hashlib-refleak

Conversation

@encukou

@encukou encukou commented May 12, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

The PyModule_AddObjectRef function doesn't steal a reference, so an extra Py_DECREF is needed.

https://bugs.python.org/issue40645

Automerge-Triggered-By: GH:tiran

@encukou
bpo-40645: Fix reference leaks in the _hashopenssl initialization …
ff1f720 
The PyModule_AddObjectRef function doesn't steal a reference,
so an extra Py_DECREF is needed.
@encukou encukou added the needs backport to 3.10 only security fixes label May 12, 2021
@encukou encukou requested a review from tiran May 12, 2021 15:40
@tiran

tiran commented May 12, 2021

Copy link
Copy Markdown
Member

Thank you!

@erlend-aasland

erlend-aasland commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

There's also three leaks in the preceding for-loop:name_obj and func => fixed in 26079

@erlend-aasland erlend-aasland mentioned this pull request May 12, 2021
Merged
@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

@encukou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3611db5 into python:main May 12, 2021
@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

Sorry @encukou, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3611db53f5b854cb6d01ee5ebb5e11c87bcc2df5 3.10

@miss-islington miss-islington self-assigned this May 12, 2021
@erlend-aasland erlend-aasland mentioned this pull request May 12, 2021
Merged
@Mariatta Mariatta removed the needs backport to 3.10 only security fixes label Jun 2, 2021
@Mariatta

Mariatta commented Jun 2, 2021

Copy link
Copy Markdown
Member

Does this still need backport to 3.10?

@erlend-aasland

erlend-aasland commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Does this still need backport to 3.10?

I believe so, yes.

cc @pablogsal.

@pablogsal

pablogsal commented Jun 3, 2021

Copy link
Copy Markdown
Member

Does this still need backport to 3.10?

I believe so, yes.

cc @pablogsal.

This indeed need to be backported

@erlend-aasland

erlend-aasland commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

I can create a backport of this together with a backport of #26079, @pablogsal. Let me know if that's ok with you, @encukou.

@encukou

encukou commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

It is. Thank you!

@encukou encukou deleted the hashlib-refleak branch June 4, 2021 08:00
@erlend-aasland

erlend-aasland commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Oh, I already did this in #26082 :) Backport is done; no further actions needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland

@tiran tiran tiran approved these changes

Assignees

@miss-islington miss-islington

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@encukou @tiran @erlend-aasland @miss-islington @Mariatta @pablogsal @the-knights-who-say-ni @bedevere-bot