{{ message }}
bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test.#2612
Merged
terryjreedy merged 15 commits intoJul 7, 2017
Merged
bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test.#2612terryjreedy merged 15 commits into
terryjreedy merged 15 commits into
Conversation
Member
Sorry, something went wrong.
|
@terryjreedy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @csabella, @asvetlov and @kbkaiser to be potential reviewers. |
Sorry, something went wrong.
mlouielu
suggested changes
Jul 7, 2017
mlouielu
left a comment
mlouielu
left a comment
Contributor
There was a problem hiding this comment.
Some method name need to consider to changed.
Sorry, something went wrong.
mlouielu
reviewed
Jul 7, 2017
mlouielu
reviewed
Jul 7, 2017
csabella
reviewed
Jul 7, 2017
csabella
reviewed
Jul 7, 2017
csabella
reviewed
Jul 7, 2017
terryjreedy
commented
Jul 7, 2017
terryjreedy
added a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 7, 2017
…, put in config; test. (pythonGH-2612) * In config, put dump test code in a function; run it and unittest in 'if __name__ == '__main__'. * Add class config.ConfigChanges based on changes_class_v4.py on bpo issue. * Add class test_config.ChangesTest, partly based on configdialog_tests_v1.py on bpo issue. * Revise configdialog to use ConfigChanges, mostly as specified in tracker msg297804. * Revise test_configdialog to match configdialog changes. All tests pass in both files. * Remove configdialog functions unused or moved to ConfigChanges. Cheryl Sabella contributed parts of the patch. (cherry picked from commit 349abd9)
terryjreedy
added a commit
that referenced
this pull request
Jul 7, 2017
…, put in config; test. (GH-2612) (#2625) * In config, put dump test code in a function; run it and unittest in 'if __name__ == '__main__'. * Add class config.ConfigChanges based on changes_class_v4.py on bpo issue. * Add class test_config.ChangesTest, partly based on configdialog_tests_v1.py on bpo issue. * Revise configdialog to use ConfigChanges, mostly as specified in tracker msg297804. * Revise test_configdialog to match configdialog changes. All tests pass in both files. * Remove configdialog functions unused or moved to ConfigChanges. Cheryl Sabella contributed parts of the patch. (cherry picked from commit 349abd9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
No description provided.