◐ Shell
reader mode source ↗
Skip to content

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368)#26414

Merged
vstinner merged 1 commit into
python:3.10from
miss-islington:backport-fba42d1-3.10
May 28, 2021
Merged

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368)#26414
vstinner merged 1 commit into
python:3.10from
miss-islington:backport-fba42d1-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented May 27, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972

@miss-islington
bpo-42972: Fully implement GC protocol for re types (pythonGH-26368) …
4507ea9 
(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 27, 2021
Merged
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes May 27, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@vstinner

vstinner commented May 27, 2021

Copy link
Copy Markdown
Member

On a single CI run, https://bugs.python.org/issue44252 occurred 3 times on 4 Windows jobs.

Tests / Windows (x86) (pull_request) Failing after 13m — Windows (x86)

=> 1 test failed: test_asyncio

Tests / Windows (x64) (pull_request) Failing after 13m — Windows (x64)

0:00:32 load avg: 6.46 [ 52/427/1] test_httplib crashed (Exit code 3221225477)
(...)
test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

Azure Pipelines PR — #20210527.52 failed

64-bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

32 bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

@vstinner

vstinner commented May 27, 2021

Copy link
Copy Markdown
Member

I re-run GHA jobs.

@vstinner vstinner merged commit da9e0cb into python:3.10 May 28, 2021
@miss-islington miss-islington deleted the backport-fba42d1-3.10 branch May 28, 2021 00:23
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot