◐ Shell
reader mode source ↗
Skip to content

bpo-44258: support PEP 515 for Fraction's initialization from string#26422

Merged
mdickinson merged 11 commits into
python:mainfrom
skirpichev:fix-44258
Jun 7, 2021
Merged

bpo-44258: support PEP 515 for Fraction's initialization from string#26422
mdickinson merged 11 commits into
python:mainfrom
skirpichev:fix-44258

Conversation

@skirpichev

@skirpichev skirpichev commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@mdickinson mdickinson self-requested a review May 28, 2021 14:56
@skirpichev

skirpichev commented May 30, 2021

Copy link
Copy Markdown
Member Author

Artifact uploading failure seems to be unrelated.

mdickinson
mdickinson reviewed May 30, 2021
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the updates. LGTM! Please could you add a doc update? I think we need a .. versionchanged entry in the main docs, and a what's new entry.

@skirpichev

skirpichev commented May 30, 2021

Copy link
Copy Markdown
Member Author

Please could you add a doc update? I think we need a .. versionchanged entry in the main docs, and a what's new entry.

I did. Lets see how it's...

mdickinson
mdickinson approved these changes May 31, 2021
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. One suggestion for rewording the .. versionchanged note.

@skirpichev

skirpichev commented May 31, 2021 via email

Copy link
Copy Markdown
Member Author

@mdickinson mdickinson merged commit 89e50ab into python:main Jun 7, 2021
@skirpichev skirpichev deleted the fix-44258 branch June 7, 2021 07:19
@skirpichev

skirpichev commented Jun 7, 2021

Copy link
Copy Markdown
Member Author

Oh, next time warn me about merging: commit message was a bit messy. If I did expect that - I would did rebase after every commit in the pr histoiry.

@mdickinson mdickinson mentioned this pull request Sep 4, 2022
Closed
@mdickinson mdickinson mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev @mdickinson @the-knights-who-say-ni @bedevere-bot