◐ Shell
reader mode source ↗
Skip to content

[3.10] bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423)#26425

Merged
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-3f8d332-3.10
May 28, 2021
Merged

[3.10] bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423)#26425
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-3f8d332-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented May 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3f8d332)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972

@miss-islington
bpo-42972: Fully implement GC protocol for functools LRU cache (pytho… …
2e1b3b7 
…nGH-26423)

(cherry picked from commit 3f8d332)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 28, 2021
Merged
vstinner
vstinner approved these changes May 28, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, good bot.

@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ❌ .

@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..

@vstinner

vstinner commented May 28, 2021

Copy link
Copy Markdown
Member

Windows (x64) failed with: https://bugs.python.org/issue44252

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation
...

I re-run the CI jobs.

@miss-islington

miss-islington commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1c0106c into python:3.10 May 28, 2021
@miss-islington miss-islington deleted the backport-3f8d332-3.10 branch May 28, 2021 14:26
@vstinner vstinner mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot