◐ Shell
reader mode source ↗
Skip to content

bpo-43858: Add logging.getLevelNamesMapping()#26459

Merged
miss-islington merged 12 commits into
python:mainfrom
akulakov:43858-add-logging-getLevelNamesDict
Jun 3, 2021
Merged

bpo-43858: Add logging.getLevelNamesMapping()#26459
miss-islington merged 12 commits into
python:mainfrom
akulakov:43858-add-logging-getLevelNamesDict

Conversation

@akulakov

@akulakov akulakov commented May 31, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Added a function that returns a copy of a dict of logging levels.

https://bugs.python.org/issue43858

@akulakov akulakov requested a review from vsajip as a code owner May 31, 2021 04:46
ericvsmith
ericvsmith requested changes May 31, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This needs tests. In particular it should add tests that a copy is returned.

@bedevere-bot

bedevere-bot commented May 31, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@akulakov

akulakov commented May 31, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 31, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith May 31, 2021 15:04
ericvsmith
ericvsmith requested changes May 31, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This is looking good to me. @vsajip : I'll let you have the final word.

@bedevere-bot

bedevere-bot commented May 31, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@akulakov

akulakov commented Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

@vsajip @ericvsmith Pushed an update per comments, please take a look!

ericvsmith
ericvsmith reviewed Jun 1, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

With the one small item I mentioned, this looks good to me.

@akulakov

akulakov commented Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

@ericvsmith I fixed the parens, please take a look..

vsajip
vsajip requested changes Jun 2, 2021
View reviewed changes

@vsajip vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Accidental double-definition in test?

@akulakov

akulakov commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

@vsajip Fixed the doubled test..

ericvsmith
ericvsmith reviewed Jun 2, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This all looks good to me. Thanks, @akulakov !

@akulakov akulakov changed the title bpo-43858: Add logging.getLevelNamesDict() Jun 2, 2021
@miss-islington miss-islington merged commit 8b93f0e into python:main Jun 3, 2021
@akulakov

akulakov commented Jun 5, 2021

Copy link
Copy Markdown
Contributor Author

@ericvsmith and @vsajip much thanks for the help with the PR!

@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith requested changes

@vsajip vsajip

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akulakov @bedevere-bot @vsajip @ericvsmith @the-knights-who-say-ni @miss-islington