◐ Shell
reader mode source ↗
Skip to content

bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows#26502

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_ssl2
Jun 3, 2021
Merged

bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows#26502
vstinner merged 1 commit into
python:mainfrom
vstinner:test_ssl2

Conversation

@vstinner

@vstinner vstinner commented Jun 3, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.

https://bugs.python.org/issue43921

@vstinner
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows …
1b6ec25 
Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
@vstinner vstinner requested a review from tiran as a code owner June 3, 2021 01:32
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 3, 2021
@vstinner vstinner added needs backport to 3.10 only security fixes and removed CLA signed awaiting core review tests Tests in the Lib/test dir labels Jun 3, 2021
@vstinner

vstinner commented Jun 3, 2021

Copy link
Copy Markdown
Member Author

See #26501 (comment) for my debug notes on this issue.

@vstinner

vstinner commented Jun 3, 2021

Copy link
Copy Markdown
Member Author

cc @tiran @pablogsal: a PR fixing test_wrong_cert_tls13() similar to (but different than) my previous PR #26489 fixing test_pha_required_nocert().

@vstinner vstinner mentioned this pull request Jun 3, 2021
Closed
@vstinner vstinner merged commit ea0210f into python:main Jun 3, 2021
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_ssl2 branch June 3, 2021 16:04
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Sorry @vstinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ea0210fa8ccca769896847f25fc6fadfe9a717bc 3.10

@vstinner vstinner added and removed needs backport to 3.10 only security fixes labels Jun 3, 2021
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 3, 2021

Copy link
Copy Markdown

GH-26518 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2021
@vstinner @miss-islington
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (pythonGH-… …
9284d4b 
…26502)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 3, 2021
@miss-islington @vstinner
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) (… …
d2ab15f 
…GH-26518)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni