{{ message }}
bpo-42213: Remove redundant cyclic GC hack in sqlite3#26517
Merged
miss-islington merged 1 commit intoJun 3, 2021
Merged
Conversation
Contributor
Sorry, something went wrong.
The sqlite3 module now fully implements the GC protocol, so there's no need for this workaround anymore. - Add and use managed resource helper for connections with fs io - Sort test imports - Split open-tests into their own test case
vstinner
approved these changes
Jun 3, 2021
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Member
|
@erlend-aasland: Don't touch anything, try the automerge label: it should merge the PR as soon as the CI pass. |
Sorry, something went wrong.
Contributor
|
@erlend-aasland: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The sqlite3 module now fully implements the GC protocol, so there's no
need for this workaround anymore.
https://bugs.python.org/issue42213
Automerge-Triggered-By: GH:vstinner