bpo-44340: Add support for building with clang thin lto via --with-lto=thin#26585
bpo-44340: Add support for building with clang thin lto via --with-lto=thin#26585holmanb wants to merge 4 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
ned-deily
left a comment
There was a problem hiding this comment.
Thanks for the PR. Without commenting on the desirability of the feature, be aware thatconfigure is a derived file produced from configure.ac by the autoconf tool. The PR needs to change configure.ac and then run autoconf and commit the resulting changes to configure too. See the devguide for more info.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
Please add the NEWS.d with blurb tool
Sorry, something went wrong.
|
@holmanb |
Sorry, something went wrong.
|
Let's run the https://github.com/python/pyperformance benchmark and compare it with full LTO |
Sorry, something went wrong.
@ned-deily The current I assume that getting this fixed upstream is a prerequisite for getting this PR merged, otherwise autoconf will generate a Perhaps a CI bot to verify that in future PRs |
Sorry, something went wrong.
This adds support for building cpython with clang's
--flto=thinoption. Existing--with-ltobehavior remains unchanged (default to no, with--with-ltocurrently using the default compiler lto option).The tests (
make test) currently pass for clang 11.1.0 for each of--with-ltoand--with-lto=thin.https://bugs.python.org/issue44340