bpo-30870: IDLE: Add configdialog fontlist unittest#2666
Conversation
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @csabella and @kbkaiser to be potential reviewers. |
Sorry, something went wrong.
terryjreedy
left a comment
There was a problem hiding this comment.
Super. Will look at tests later.
Sorry, something went wrong.
|
Appveyor, running on Windows, and my Win 10 machine, say: FAIL: test_key_up_down_should_change_font_and_sample (idlelib.idle_test.test_configdialog.FontTabTest) |
Sorry, something went wrong.
|
@terryjreedy I think the assertion is correct, the result we want to pass is the |
Sorry, something went wrong.
|
After adding |
Sorry, something went wrong.
|
@mlouielu I initially mis-interpreted Appveyor result before I ran test myself and realized that the failure was correct and pointed to a need for a fix. I presume focus_force created no problem on your Linux. |
Sorry, something went wrong.
|
I have reviewed and am revising and will push for review and test. Please don't push any more commits for now. |
Sorry, something went wrong.
|
Changes:
|
Sorry, something went wrong.
|
@terryjreedy Thanks for your help, this makes the test more reliable. I fix some nit point about styling. Otherwise LGTM. |
Sorry, something went wrong.
…ythonGH-2666) Initial patch by Louie Lu. (cherry picked from commit 9b622fb)
No description provided.