◐ Shell
reader mode source ↗
Skip to content

bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects#26677

Merged
markshannon merged 2 commits into
python:mainfrom
isidentical:bpo-44313
Jun 30, 2021
Merged

bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects#26677
markshannon merged 2 commits into
python:mainfrom
isidentical:bpo-44313

Conversation

@isidentical

@isidentical isidentical commented Jun 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@isidentical isidentical requested a review from markshannon June 11, 2021 17:43
@isidentical isidentical changed the title bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported ob… Jun 11, 2021
@isidentical isidentical force-pushed the bpo-44313 branch 4 times, most recently from 86f2a4d to c7c708c Compare June 11, 2021 18:22
markshannon
markshannon requested changes Jun 14, 2021
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Great. Just two very minor issues.

@bedevere-bot

bedevere-bot commented Jun 14, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@isidentical

isidentical commented Jun 18, 2021

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 18, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from markshannon June 18, 2021 21:18
@Fidget-Spinner Fidget-Spinner mentioned this pull request Jun 29, 2021
Merged
markshannon
markshannon approved these changes Jun 29, 2021
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good now.
Sorry I missed your update, so importlib needs updating again.

@isidentical

isidentical commented Jun 29, 2021

Copy link
Copy Markdown
Member Author

Okay will regenerate them tomorrow.

@isidentical isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2021
@bedevere-bot

bedevere-bot commented Jun 30, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @isidentical for commit ab1b6c1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2021
@markshannon

markshannon commented Jun 30, 2021

Copy link
Copy Markdown
Member

Thanks.

@markshannon markshannon merged commit 1b28187 into python:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde left review comments

@markshannon markshannon markshannon approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isidentical @bedevere-bot @markshannon @Fidget-Spinner @sweeneyde @the-knights-who-say-ni