◐ Shell
reader mode source ↗
Skip to content

bpo-44297: Fix missing line number in generator expressions#26801

Merged
markshannon merged 3 commits into
python:mainfrom
markshannon:fix-missing-line-number-gen-expr
Jun 21, 2021
Merged

bpo-44297: Fix missing line number in generator expressions#26801
markshannon merged 3 commits into
python:mainfrom
markshannon:fix-missing-line-number-gen-expr

Conversation

@markshannon

@markshannon markshannon commented Jun 19, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is an old latent bug, that was fixed up by later compiler passes up to 3.9.

https://bugs.python.org/issue44297

@markshannon markshannon added the needs backport to 3.10 only security fixes label Jun 19, 2021
gvanrossum
gvanrossum approved these changes Jun 19, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good to me.

@gvanrossum

gvanrossum commented Jun 19, 2021

Copy link
Copy Markdown
Member

There seems to be an unrelated problem with test_logging; its test_race subtest looks flakey.

@markshannon markshannon reopened this Jun 21, 2021
@markshannon markshannon merged commit 82e5c28 into python:main Jun 21, 2021
@miss-islington

miss-islington commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 82e5c28af7049c4f5343c808f172cbe2e145f49b 3.10

markshannon added a commit to markshannon/cpython that referenced this pull request Jun 21, 2021
@markshannon
bpo-44297: Fix missing line number in generator expressions (pythonGH… …
b933e81 
…-26801)

* Make sure that line number is set when entering comprehension scope in compiler.

(cherry picked from commit 82e5c28)
@pablogsal

pablogsal commented Jun 21, 2021

Copy link
Copy Markdown
Member

#26782 seems to be related, @markshannon can you take a look please?

@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

@markshannon markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@markshannon @gvanrossum @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot @ZeroIntensity