{{ message }}
bpo-40939: Remove documentation for PyParser_* & add porting notes#26855
Merged
encukou merged 3 commits intoJun 24, 2021
Merged
bpo-40939: Remove documentation for PyParser_* & add porting notes#26855encukou merged 3 commits into
PyParser_* & add porting notes#26855encukou merged 3 commits into
Conversation
Member
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jun 22, 2021
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
This LGTM. Thanks for doing this. I like how the porting guide covers the 3 main input types for AST construction in the old API.
Sorry, something went wrong.
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Contributor
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2021
…ythonGH-26855) I tried to be relatively thorough and give lots of links. One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs. Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 29987f7) Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
added a commit
that referenced
this pull request
Jun 28, 2021
…H-26855) (GH-26898) I tried to be relatively thorough and give lots of links. One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs. (cherry picked from commit 29987f7) Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
I tried to be relatively thorough and give lots of links.
One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs.
https://bugs.python.org/issue40939