◐ Shell
reader mode source ↗
Skip to content

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2#26884

Merged
miss-islington merged 5 commits into
python:mainfrom
erlend-aasland:sqlite-move-err/2
Jul 14, 2021
Merged

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2#26884
miss-islington merged 5 commits into
python:mainfrom
erlend-aasland:sqlite-move-err/2

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 23, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42064

Automerge-Triggered-By: GH:encukou

@erlend-aasland erlend-aasland requested a review from encukou June 23, 2021 20:11
@erlend-aasland

erlend-aasland commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

FYI, for check_cursor and pysqlite_check_connection, we cannot rely on the connection context exception pointers (at least not for the early sanity checks), so I'm using the global state in those methods.

@erlend-aasland

erlend-aasland commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

(Re-opening to trigger CI again)

@erlend-aasland

erlend-aasland commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

cc. @encukou

Erlend E. Aasland added 2 commits July 13, 2021 23:10
encukou
encukou approved these changes Jul 14, 2021
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good, thanks!

@miss-islington miss-islington merged commit 0516299 into python:main Jul 14, 2021
@erlend-aasland

erlend-aasland commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

Looks good, thanks!

Thanks for reviewing!

@erlend-aasland erlend-aasland deleted the sqlite-move-err/2 branch July 14, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @encukou @the-knights-who-say-ni @bedevere-bot @miss-islington