◐ Shell
reader mode source ↗
Skip to content

[3.10] bpo-43988: Add test.support.check_disallow_instantiation() (GH-25757)#26885

Merged
miss-islington merged 5 commits into
python:3.10from
erlend-aasland:backport-4f72526-3.10
Jun 23, 2021
Merged

[3.10] bpo-43988: Add test.support.check_disallow_instantiation() (GH-25757)#26885
miss-islington merged 5 commits into
python:3.10from
erlend-aasland:backport-4f72526-3.10

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 4f72526, fbff538, and 8cec740)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue43988

Automerge-Triggered-By: GH:vstinner

[3.10] bpo-43988: Add test.support.check_disallow_instantiation() (py… …
9122e87 
…thonGH-25757).

(cherry picked from commit 4f72526)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland requested a review from pablogsal June 23, 2021 21:17
@erlend-aasland

erlend-aasland commented Jun 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'll backport GH-26392, GH-26394, and GH-26412 after this has been merged.

EDIT: the two former PR's have been included in this backport PR, as they belong to the same bpo issue.

@erlend-aasland erlend-aasland requested a review from vstinner June 23, 2021 21:32
@erlend-aasland erlend-aasland force-pushed the backport-4f72526-3.10 branch from 8c4938c to d7c99d8 Compare June 23, 2021 21:33
@erlend-aasland erlend-aasland mentioned this pull request Jun 23, 2021
Merged
vstinner
vstinner approved these changes Jun 23, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. But please fix the doc.

vstinner
vstinner approved these changes Jun 23, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thanks.

@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@erlend-aasland

erlend-aasland commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

test_ttk_guionly failed on Ubuntu in Azure Pipelines.

2021-06-23T22:15:57.5133290Z ======================================================================
2021-06-23T22:15:57.5133791Z FAIL: test_configure_to (tkinter.test.test_ttk.test_widgets.SpinboxTest)
2021-06-23T22:15:57.5134904Z ----------------------------------------------------------------------
2021-06-23T22:15:57.5135381Z Traceback (most recent call last):
2021-06-23T22:15:57.5135890Z   File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1175, in test_configure_to
2021-06-23T22:15:57.5136405Z     self._click_increment_arrow()  # 5
2021-06-23T22:15:57.5136909Z   File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1135, in _click_increment_arrow
2021-06-23T22:15:57.5137627Z     self.assertRegex(self.spin.identify(x, y), r'.*uparrow\Z')
2021-06-23T22:15:57.5138321Z AssertionError: Regex didn't match: '.*uparrow\\Z' not found in ''

@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0a3452e into python:3.10 Jun 23, 2021
@erlend-aasland erlend-aasland deleted the backport-4f72526-3.10 branch June 24, 2021 05:55
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@pablogsal pablogsal

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot