◐ Shell
reader mode source ↗
Skip to content

bpo-30256: Fix rst in news#26994

Merged
iritkatriel merged 2 commits into
python:mainfrom
Fidget-Spinner:fix_news
Jul 2, 2021
Merged

bpo-30256: Fix rst in news#26994
iritkatriel merged 2 commits into
python:mainfrom
Fidget-Spinner:fix_news

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jul 2, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Unblocks the docs CI. Currently PR CIs fail with the following error:

python tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2019-09-25-13-54-41.[bpo-30256](https://bugs.python.org/issue30256).wBkzox.rst:1: default role used
1 problem with severity 2 found.
Makefile:204: recipe for target 'check' failed

https://bugs.python.org/issue30256

@Fidget-Spinner Fidget-Spinner mentioned this pull request Jul 2, 2021
Merged
@iritkatriel iritkatriel changed the title bpo-30256: Fix rST in news Jul 2, 2021
@iritkatriel iritkatriel merged commit 2560c61 into python:main Jul 2, 2021
@miss-islington

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Sorry @Fidget-Spinner and @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2560c612c89ea2534b90a266aabf76dc74d93a12 3.10

@bedevere-bot

bedevere-bot commented Jul 2, 2021

Copy link
Copy Markdown

GH-26996 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 2, 2021
@Fidget-Spinner @miss-islington
bpo-30256: [doc] Fix formatting error in news (pythonGH-26994) …
94274fd 
(cherry picked from commit 2560c61)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Jul 2, 2021
@iritkatriel
[3.10] bpo-30256: [doc] Fix formatting error in news (GH-26994)
647a4bb
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 2, 2021
@bedevere-bot

bedevere-bot commented Jul 2, 2021

Copy link
Copy Markdown

GH-26998 is a backport of this pull request to the 3.10 branch.

iritkatriel pushed a commit that referenced this pull request Jul 2, 2021
@miss-islington @Fidget-Spinner
bpo-30256: [doc] Fix formatting error in news (GH-26994) (GH-26996) …
91db097 
(cherry picked from commit 2560c61)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Jul 2, 2021
@iritkatriel
[3.10] bpo-30256: [doc] Fix formatting error in news (GH-26994) (GH-2… …
7a2d2ed 
…6998)
@iritkatriel

iritkatriel commented Jul 2, 2021

Copy link
Copy Markdown
Member

Thanks @Fidget-Spinner !

@Fidget-Spinner Fidget-Spinner deleted the fix_news branch July 3, 2021 06:45
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@iritkatriel iritkatriel

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fidget-Spinner @miss-islington @bedevere-bot @iritkatriel @the-knights-who-say-ni