◐ Shell
reader mode source ↗
Skip to content

Clean up comma usage in Doc/library/functions.rst#27083

Merged
ambv merged 15 commits into
python:mainfrom
Adminixtrator:main
Jul 19, 2021
Merged

Clean up comma usage in Doc/library/functions.rst#27083
ambv merged 15 commits into
python:mainfrom
Adminixtrator:main

Conversation

@Adminixtrator

@Adminixtrator Adminixtrator commented Jul 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

"Readability counts."

Excerpt from The Zen of Python by Tim Peters

@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 10, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Adminixtrator

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jul 10, 2021
ambv
ambv reviewed Jul 13, 2021
View reviewed changes
2 hidden conversations Load more…
Adminixtrator
Adminixtrator commented Jul 16, 2021
View reviewed changes

@Adminixtrator Adminixtrator left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hi @ambv
Once resolved, should I fix these and create a new PR or that will be done from your end?

@ambv

ambv commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Once resolved, should I fix these and create a new PR or that will be done from your end?

I'm not sure what you mean. You resolve issues by updating your PR. I'll merge it once it's in an acceptable state.

Adminixtrator
Adminixtrator commented Jul 18, 2021
View reviewed changes

@Adminixtrator Adminixtrator left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

All done @ambv

@ambv ambv changed the title --improved readability Jul 19, 2021
@ambv ambv changed the title Clean up comma usage Jul 19, 2021
@ambv ambv merged commit 1e651c6 into python:main Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv

ambv commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Thanks! ✨ 🍰 ✨

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 19, 2021
@sthagen
Merge pull request #541 from python/main …
f209a64 
Clean up comma usage in Doc/library/functions.rst (python#27083)
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 19, 2021
@miss-islington

miss-islington commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @Adminixtrator for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2021
@Adminixtrator @miss-islington
Clean up comma usage in Doc/library/functions.rst (pythonGH-27083) …
68dec1c 
(cherry picked from commit 1e651c6)

Co-authored-by: α∂мιηιχтяαтσя <sadiqherritage@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

GH-27243 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 19, 2021
ambv pushed a commit that referenced this pull request Jul 19, 2021
@miss-islington @Adminixtrator
Clean up comma usage in Doc/library/functions.rst (GH-27083) (#27243) …
2d04920 
(cherry picked from commit 1e651c6)

Co-authored-by: α∂мιηιχтяαтσя <sadiqherritage@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035 …
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

Assignees

No one assigned

Labels

docs skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Adminixtrator @the-knights-who-say-ni @ambv @bedevere-bot @miss-islington