◐ Shell
reader mode source ↗
Skip to content

[3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048)#27222

Merged
gvanrossum merged 1 commit into
python:3.10from
Fidget-Spinner:test_push
Jul 19, 2021
Merged

[3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048)#27222
gvanrossum merged 1 commit into
python:3.10from
Fidget-Spinner:test_push

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jul 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit bf89ff9)

Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com

https://bugs.python.org/issue44490

@uriyyo @miss-islington
bpo-44490: Improve typing module compatibility with types.Union (pyth… …
4ed37b5 
…onGH-27048)

(cherry picked from commit bf89ff9)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
@Fidget-Spinner Fidget-Spinner removed the request for review from gvanrossum July 18, 2021 07:17
@Fidget-Spinner Fidget-Spinner changed the title Improve typing module compatibility with types.Union (GH-27048) Jul 18, 2021
@Fidget-Spinner Fidget-Spinner mentioned this pull request Jul 18, 2021
Closed
gvanrossum
gvanrossum approved these changes Jul 19, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Yeah, looks good to me too.

What happens next? Will it be merged automatically? Does Pablo need to do it? Can we do it?

@Fidget-Spinner

Fidget-Spinner commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

Can we do it?

I think so. I asked Pablo the previous time because that change was quite big, touched lots of C code and added new features.

This time, it's smaller, only touching Python code, and IMO it's a bug. Without this fix we can't mix and match the Union type and typing types.

@gvanrossum gvanrossum merged commit a272164 into python:3.10 Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the test_push branch July 19, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Fidget-Spinner @bedevere-bot @gvanrossum @serhiy-storchaka @the-knights-who-say-ni @uriyyo