◐ Shell
reader mode source ↗
Skip to content

bpo-44524: Add missed __name__ and __qualname__ to typing module objects#27237

Merged
ambv merged 6 commits into
python:mainfrom
uriyyo:fix-issue-44524
Jul 19, 2021
Merged

bpo-44524: Add missed __name__ and __qualname__ to typing module objects#27237
ambv merged 6 commits into
python:mainfrom
uriyyo:fix-issue-44524

Conversation

@uriyyo

@uriyyo uriyyo commented Jul 19, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@uriyyo uriyyo requested a review from gvanrossum as a code owner July 19, 2021 11:07
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo

uriyyo commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ambv July 19, 2021 13:03
@ambv

ambv commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Oops, you're actually right, @uriyyo, __qualname__ omits the module as explained in PEP 3155. Sorry, got confused by the comments on the issue. Can you please revert to what you had before? 🙊🙈🙉

@uriyyo

uriyyo commented Jul 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ambv Fixed) Should we mention it at issue tracker? (I am talking about Guido comment)

@Fidget-Spinner

Fidget-Spinner commented Jul 19, 2021

Copy link
Copy Markdown
Member

I like how clean this change is for the collections.abc types :).

On the issue, Lars (the bug reporter), also requested for the special forms (Union, Any, etc.) to have __name__. So you may have to add it for the _SpecialForm decorator too. However, there isn't a clear consensus yet. So let's wait a little.

@ambv

ambv commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

There's consensus now. Please add _SpecialForm dunder-names too, please.

@uriyyo

uriyyo commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

@ambv Added. Thanks for notifying about final decision)

Fidget-Spinner
Fidget-Spinner reviewed Jul 19, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Few minor comments.

uriyyo and others added 2 commits July 19, 2021 19:38
Fidget-Spinner
Fidget-Spinner approved these changes Jul 19, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the patch! Passing the ball over to Łukasz or Guido now :).

gvanrossum
gvanrossum approved these changes Jul 19, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. @ambv can you merge?

@ambv

ambv commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Yessir! As soon as macOS tests are done.

@ambv ambv merged commit bce1418 into python:main Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv added the needs backport to 3.10 only security fixes label Jul 19, 2021
@miss-islington

miss-islington commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

GH-27246 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2021
@uriyyo @miss-islington
bpo-44524: Add missed __name__ and __qualname__ to typing module obje… …
8e5ef31 
…cts (pythonGH-27237)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
(cherry picked from commit bce1418)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
ambv pushed a commit that referenced this pull request Jul 19, 2021
@miss-islington @uriyyo
bpo-44524: Add missed __name__ and __qualname__ to typing module obje… …
c895f2b 
…cts (GH-27237) (#27246)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
(cherry picked from commit bce1418)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035 …
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
@BvB93 BvB93 mentioned this pull request Aug 4, 2021
Merged
@farcat farcat mannequin mentioned this pull request Apr 14, 2022
Closed
@christophebedard christophebedard mentioned this pull request Jun 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@uriyyo @bedevere-bot @ambv @Fidget-Spinner @miss-islington @gvanrossum @the-knights-who-say-ni