◐ Shell
reader mode source ↗
Skip to content

bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write#27271

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-42854
Jul 23, 2021
Merged

bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write#27271
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-42854

Conversation

@pablogsal

@pablogsal pablogsal commented Jul 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from tiran July 20, 2021 20:52
tiran
tiran requested changes Jul 21, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

There are a bunch of warnings related to signed and unsigned comparison, e.g. comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘Py_ssize_t’ {aka ‘long int’} [-Wsign-compare]. Maybe use Py_ssize_t?

@bedevere-bot

bedevere-bot commented Jul 21, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal pablogsal requested a review from tiran July 21, 2021 12:02
@pablogsal

pablogsal commented Jul 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm landing this as there is no compiler warnings anymore and I don't want to commit this very close to the rc.

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 23, 2021
@pablogsal pablogsal merged commit 83d1430 into python:main Jul 23, 2021
@pablogsal pablogsal deleted the bpo-42854 branch July 23, 2021 15:05
@miss-islington

miss-islington commented Jul 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 23, 2021

Copy link
Copy Markdown

GH-27308 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 23, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2021
@pablogsal @miss-islington
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SS… …
f4f3f3c 
…LSocket.write (pythonGH-27271)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jul 23, 2021
@miss-islington @pablogsal
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SS… …
5ec2757 
…LSocket.write (GH-27271) (GH-27308)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@python python deleted a comment from bedevere-bot Jul 23, 2021
tiran added a commit to tiran/cpython that referenced this pull request Aug 3, 2022
@tiran
Revert "bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and … …
609c743 
…_ssl._SSLSocket.write (pythonGH-27271)"

This reverts commit 83d1430.
@tiran tiran mentioned this pull request Aug 3, 2022
Closed
tiran added a commit to tiran/cpython that referenced this pull request Aug 3, 2022
@tiran
Revert "bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and … …
ca3d2be 
…_ssl._SSLSocket.write (pythonGH-27271)"

This reverts commit 83d1430.
@tiran tiran mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @bedevere-bot @miss-islington @tiran @the-knights-who-say-ni