bpo-44712: Replace "type(literal)" with corresponding builtin types#27294
bpo-44712: Replace "type(literal)" with corresponding builtin types#27294serhiy-storchaka merged 7 commits into
Conversation
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
Sorry, something went wrong.
|
The type(x) replacements are a real improvement in readability. Consider removing other changes while adding a few ==/!= replacements with is/is not. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
ronaldoussoren
left a comment
ronaldoussoren
left a comment
There was a problem hiding this comment.
The changes to plistlib and build-installer.py look good to me.
Likewise for most other changes. This does change type checks from (effectively) type(value) is some_type to instance(value, some_type) and those are technically semantic changes. That said, the changes should have no visible behaviour change in practice.
I didn't look at the changes in tkinter, pydoc and xmlrpc, mostly due to lack of time: I didn't have to time to look deeply enough at the code to see if there are unexpected changes in behaviour.
Sorry, something went wrong.
Reviewers
6 participants
https://bugs.python.org/issue44712
#88878