bpo-42064: Pass module state to sqlite3 UDF callbacks#27456
Conversation
|
A couple of questions, @encukou:
|
Sorry, something went wrong.
There are very few funcitons in the C-API that you can call without the GIL held; usually they're the ones needed before a GIL is created. For |
Sorry, something went wrong.
Yes, I've seen it ;) But then why does this PR work as it is? (That is, without the GIL) (FYI: I'll update the PR with GIL wrappers soon) |
Sorry, something went wrong.
I assume it's because you're not using multiple threads. |
Sorry, something went wrong.
Ah, right. Thanks! I've updated the PR. PTAL :) |
Sorry, something went wrong.
Sorry, something went wrong.
encukou
left a comment
There was a problem hiding this comment.
I found some more questionable uses of the GIL in existing code (see the issue). But let's not block this PR; it is an improvement.
Sorry, something went wrong.
|
Thanks for reviewing! |
Sorry, something went wrong.
https://bugs.python.org/issue42064
Automerge-Triggered-By: GH:encukou