bpo-44859: Improve error handling in sqlite3 and change some errors#27654
bpo-44859: Improve error handling in sqlite3 and change some errors#27654serhiy-storchaka merged 2 commits into
Conversation
Sorry, something went wrong.
* MemoryError is now raised instead of sqlite3.Warning when memory is not enough for encoding a statement to UTF-8 in Connection.__call__() and Cursor.execute(). * UnicodEncodeError is now raised instead of sqlite3.Warning when the statement contains surrogate characters in Connection.__call__() and Cursor.execute(). * TypeError is now raised instead of ValueError for non-string script argument in Cursor.executescript(). * ValueError is now raised for script containing the null character instead of truncating it in Cursor.executescript(). * Correctly handle exceptions raised when getting boolean value of the result of the progress handler. * Add may tests covering different exceptional cases.
serhiy-storchaka
added
type-bug
An unexpected behavior, bug, or error
tests
Tests in the Lib/test dir
labels
Aug 7, 2021
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM, in general. Region coverage for util.c is now above 80%; sqlite3 coverage is getting better and better.
I left some minor comments.
Sorry, something went wrong.
|
BTW, that's a neat enhancement of the |
Sorry, something went wrong.
|
We should consider changing some more errors, as discussed in #27642 (comment), #27645 (comment), and #27645 (comment) |
Sorry, something went wrong.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Reviewers
4 participants
memory is not enough for encoding a statement to UTF-8
in Connection.call() and Cursor.execute().
the statement contains surrogate characters
in
Connection.__call__()and Cursor.execute().script argument in Cursor.executescript().
character instead of truncating it in Cursor.executescript().
of the result of the progress handler.
https://bugs.python.org/issue44859