◐ Shell
reader mode source ↗
Skip to content

bpo-26184: import.rst: Add versionchanged note#277

Merged
Mariatta merged 1 commit into
python:masterfrom
Mariatta:bpo-26184-master
Feb 26, 2017
Merged

bpo-26184: import.rst: Add versionchanged note#277
Mariatta merged 1 commit into
python:masterfrom
Mariatta:bpo-26184-master

Conversation

@Mariatta

@Mariatta Mariatta commented Feb 24, 2017

Copy link
Copy Markdown
Member

Add versionchanged note indicating that an ImportError is raised when exec_module() is defined, but create_module() is not.

http://bugs.python.org/issue26184

@Mariatta
bpo-26184: import.rst: Add versionchanged note indicating that …
6f92989 
an ImportError is raised when exec_module() is defined, but
create_module() is not.
@Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 24, 2017
marco-buttu
marco-buttu suggested changes Feb 24, 2017
View reviewed changes

@marco-buttu marco-buttu left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hi @Mariatta , it LGTM, but I would like you to add just a minor change, not directly related with this PR. In the first versionadded of the Loaders section, we do not have any markup for create_module():

.. versionadded:: 3.4
   The create_module() method of loaders.

It should be:

.. versionadded:: 3.4
   The :meth:`~importlib.abc.Loader.create_module`  method of loaders.

Thank you very much

@Mariatta

Mariatta commented Feb 25, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review, @Carreau and @marco-buttu .

@marco-buttu, the change that you requested will require backport to 3.5 and 3.6 branches, whereas this PR will only be backported to 3.6.

I will make that change as a separate PR from this.

@marco-buttu

marco-buttu commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

@Mariatta I opened a bpo-29648 issue for the missing reference to create_module(). I am making the PR.

@Mariatta Mariatta merged commit 6b4a5f4 into python:master Feb 26, 2017
Mariatta added a commit to Mariatta/cpython that referenced this pull request Feb 26, 2017
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (pythonGH-277) …
dedda76 
Mention that an ImportError is raised when exec_module() is defined, but
create_module() is not.
(cherry picked from commit 6b4a5f4)
@Mariatta Mariatta deleted the bpo-26184-master branch February 26, 2017 15:42
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (GH-277) (#320) …
deea29e 
(cherry picked from commit 6b4a5f4)
akruis added a commit to akruis/cpython that referenced this pull request Jun 30, 2021
@akruis
Stackless issue python#277: Convert Stackless demos to Python3 …
8487430 
Convert all files to Python3 and run/test them once.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump sentry-sdk from 0.11.2 to 0.12.1 (#277)
13dc739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag left review comments

+2 more reviewers

@Carreau Carreau Carreau approved these changes

@marco-buttu marco-buttu marco-buttu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mariatta @marco-buttu @berkerpeksag @Carreau @the-knights-who-say-ni