◐ Shell
reader mode source ↗
Skip to content

bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions#27729

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:bpo-44885
Aug 12, 2021
Merged

bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions#27729
pablogsal merged 3 commits into
python:mainfrom
pablogsal:bpo-44885

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from lysnikolaou as a code owner August 11, 2021 15:39
@pablogsal pablogsal force-pushed the bpo-44885 branch 3 times, most recently from 4bfd0dc to 528cb29 Compare August 11, 2021 15:53
@pablogsal @isidentical
Update Parser/string_parser.c …
2059d9e 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
isidentical
isidentical approved these changes Aug 12, 2021
View reviewed changes

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@pablogsal pablogsal merged commit 8e832fb into python:main Aug 12, 2021
@pablogsal pablogsal deleted the bpo-44885 branch August 12, 2021 16:13
@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.9

@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.10

@pablogsal pablogsal mentioned this pull request Aug 12, 2021
Merged
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
@pablogsal
[3.10] bpo-44885: Correct the ast locations of f-strings with format … …
af8b020 
…specs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented Aug 12, 2021

Copy link
Copy Markdown

GH-27743 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

bedevere-bot commented Aug 12, 2021

Copy link
Copy Markdown

GH-27744 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s… …
b01000e 
…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 12, 2021
@pablogsal
[3.10] bpo-44885: Correct the ast locations of f-strings with format … …
c28c2e1 
…specs and repeated expressions (GH-27729) (GH-27743)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 12, 2021
@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s… …
4b86c9c 
…pecs and repeated expressions (GH-27729) (GH-27744)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@DanielNoord DanielNoord mentioned this pull request Mar 16, 2022
Closed
@wookayin wookayin mentioned this pull request Sep 18, 2022
Open
@alexmojaki alexmojaki mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes

@isidentical isidentical isidentical approved these changes

@lysnikolaou lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @ammaraskar @isidentical @the-knights-who-say-ni