◐ Shell
reader mode source ↗
Skip to content

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729)#27744

Merged
pablogsal merged 1 commit into
python:3.9from
pablogsal:backport-8e832fb-3.9
Aug 12, 2021
Merged

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729)#27744
pablogsal merged 1 commit into
python:3.9from
pablogsal:backport-8e832fb-3.9

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 12, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com

https://bugs.python.org/issue44885

@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s… …
b01000e 
…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal requested a review from lysnikolaou as a code owner August 12, 2021 16:25
@bedevere-bot bedevere-bot mentioned this pull request Aug 12, 2021
Merged
@pablogsal pablogsal force-pushed the backport-8e832fb-3.9 branch from 19b04bf to b01000e Compare August 12, 2021 16:41
@pablogsal pablogsal merged commit 4b86c9c into python:3.9 Aug 12, 2021
@pablogsal pablogsal deleted the backport-8e832fb-3.9 branch August 12, 2021 17:46
@isidentical

isidentical commented Aug 12, 2021

Copy link
Copy Markdown
Member

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

@pablogsal

pablogsal commented Aug 12, 2021

Copy link
Copy Markdown
Member Author

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

We have one that probably will fail soon :(

I will fix it if I can, but I have already removed some tests to avoid failures. If I cannot fix it we may need to revert :(

@pablogsal

pablogsal commented Aug 12, 2021

Copy link
Copy Markdown
Member Author

Fixed by #27749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot