◐ Shell
reader mode source ↗
Skip to content

bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only#28002

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
cfbolz:cpython-only-test-error-block-nesting
Aug 28, 2021
Merged

bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only#28002
serhiy-storchaka merged 1 commit into
python:mainfrom
cfbolz:cpython-only-test-error-block-nesting

Conversation

@cfbolz

@cfbolz cfbolz commented Aug 27, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

PyPy and potentially other implementations have different or no
constraints on the number of blocks that can be statically nested. move
the doctest that checks for this behaviour into a unit test and mark it as
CPython-only.

In PyPy, the doctest happily looped forever, because there is no syntax error raised 😞

https://bugs.python.org/issue25130

@cfbolz
move test that is cpython only to a unit-test, and add decorator …
423138c 
PyPy and potentially other implementations have different or no
contraints on the number of blocks that can be statically nested. move
the test that checks for this behaviour into a unit test and mark it as
CPython-only.
@bedevere-bot bedevere-bot added awaiting review Tests in the Lib/test dir labels Aug 27, 2021
@serhiy-storchaka serhiy-storchaka changed the title Make unit-test about restricting the maximum number of nested blocks cpython-only Aug 28, 2021
@serhiy-storchaka serhiy-storchaka merged commit eb263f9 into python:main Aug 28, 2021
@miss-islington

miss-islington commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @cfbolz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Sorry, @cfbolz and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eb263f9a356f5c5f21b8d5ce20bac92f31c40cad 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 28, 2021
@bedevere-bot

bedevere-bot commented Aug 28, 2021

Copy link
Copy Markdown

GH-28016 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 28, 2021
@cfbolz @miss-islington
bpo-25130: Make unit-test about restricting the maximum number of nes… …
9a486ed 
…ted blocks cpython-only (pythonGH-28002)

PyPy and potentially other implementations have different or no
contraints on the number of blocks that can be statically nested. move
the test that checks for this behaviour into a unit test and mark it as
CPython-only.
(cherry picked from commit eb263f9)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@miss-islington

miss-islington commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @cfbolz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Sorry @cfbolz and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker eb263f9a356f5c5f21b8d5ce20bac92f31c40cad 3.9

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Aug 28, 2021
@cfbolz @serhiy-storchaka
[3.9] bpo-25130: Make unit-test about restricting the maximum number … …
e932bb0 
…of nested blocks cpython-only (pythonGH-28002)

PyPy and potentially other implementations have different or no
contraints on the number of blocks that can be statically nested. move
the test that checks for this behaviour into a unit test and mark it as
CPython-only..
(cherry picked from commit eb263f9)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 28, 2021
Merged
@bedevere-bot

bedevere-bot commented Aug 28, 2021

Copy link
Copy Markdown

GH-28017 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka pushed a commit that referenced this pull request Aug 28, 2021
@miss-islington @cfbolz
bpo-25130: Make unit-test about restricting the maximum number of nes… …
779b9ae 
…ted blocks cpython-only (GH-28002) (GH-28016)

PyPy and potentially other implementations have different or no
contraints on the number of blocks that can be statically nested. move
the test that checks for this behaviour into a unit test and mark it as
CPython-only.
(cherry picked from commit eb263f9)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
serhiy-storchaka added a commit that referenced this pull request Aug 28, 2021
@serhiy-storchaka @cfbolz
[3.9] bpo-25130: Make unit-test about restricting the maximum number … …
1046cd0 
…of nested blocks cpython-only (GH-28002) (GH-28017)

PyPy and potentially other implementations have different or no
contraints on the number of blocks that can be statically nested. move
the test that checks for this behaviour into a unit test and mark it as
CPython-only..
(cherry picked from commit eb263f9)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
mozillazg pushed a commit to mozillazg/pypy that referenced this pull request Aug 29, 2021
@cfbolz
move the test, submitted to cpython too: python/cpython#28002
1ea3975
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cfbolz @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni