◐ Shell
reader mode source ↗
Skip to content

bpo-44991: Normalise sqlite3 callback naming#28088

Merged
encukou merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-normlise-callback-naming
Sep 7, 2021
Merged

bpo-44991: Normalise sqlite3 callback naming#28088
encukou merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-normlise-callback-naming

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 31, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland requested a review from encukou August 31, 2021 12:58
@encukou

encukou commented Sep 1, 2021

Copy link
Copy Markdown
Member

What about _destructor?

This PR turns out to be very small; maybe combine it with the next step if there is one coming?

@erlend-aasland

erlend-aasland commented Sep 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

What about _destructor?

Thanks for the heads-up. I'll add it right away.

This PR turns out to be very small; maybe combine it with the next step if there is one coming?

The next step of normalising is approximately 100 lines added and removed; I think it would clutter things too much. I'm fine with that, but it may be more timeconsuming to review.

@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise sqlite3 callback suffixes Sep 1, 2021
@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise sqlite3 callbacks, part 1 Sep 1, 2021
@erlend-aasland

erlend-aasland commented Sep 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'll include the other changes; if you think it's too much, we can just revert that commit.

I see the diff wasn't as bad as I expected. Only 60-ish lines.

Further normalising: …
0a9d214 
- all callbacks are now named xxx_callback
- normalise callable naming in set_*() functions
- normalise context argument naming in callbacks
@erlend-aasland erlend-aasland force-pushed the sqlite-normlise-callback-naming branch from df3becb to 0a9d214 Compare September 1, 2021 15:57
@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise sqlite3 callback naming, part 1 Sep 1, 2021
@erlend-aasland erlend-aasland mentioned this pull request Sep 1, 2021
Merged
@encukou encukou merged commit 0474d06 into python:main Sep 7, 2021
@erlend-aasland erlend-aasland deleted the sqlite-normlise-callback-naming branch September 7, 2021 11:46
@erlend-aasland erlend-aasland mentioned this pull request Sep 7, 2021
Merged
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@encukou encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @encukou @the-knights-who-say-ni @bedevere-bot