◐ Shell
reader mode source ↗
Skip to content

bpo-30993: IDLE - Improve configdialog font page and tests. #2818

Merged
terryjreedy merged 3 commits into
python:masterfrom
terryjreedy:fontchange
Jul 23, 2017
Merged

bpo-30993: IDLE - Improve configdialog font page and tests. #2818
terryjreedy merged 3 commits into
python:masterfrom
terryjreedy:fontchange

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Jul 22, 2017

Copy link
Copy Markdown
Member

@mention-bot

Copy link
Copy Markdown

@terryjreedy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @csabella, @kbkaiser and @zooba to be potential reviewers.

@terryjreedy

Copy link
Copy Markdown
Member Author

screwed up, will try again

* Document causal pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
@terryjreedy terryjreedy reopened this Jul 22, 2017
@terryjreedy terryjreedy changed the title Fontchange Jul 22, 2017
@terryjreedy terryjreedy self-assigned this Jul 23, 2017
@terryjreedy terryjreedy merged commit 07ba305 into python:master Jul 23, 2017
@terryjreedy terryjreedy deleted the fontchange branch July 23, 2017 16:20
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 23, 2017
…thonGH-2818)

* Document causal event pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
(cherry picked from commit 07ba305)
terryjreedy added a commit that referenced this pull request Jul 23, 2017
…-2818) (#2826)

* Document causal event pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
(cherry picked from commit 07ba305)
@terryjreedy terryjreedy restored the fontchange branch July 23, 2017 20:21
@terryjreedy terryjreedy deleted the fontchange branch July 23, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants