◐ Shell
reader mode source ↗
Skip to content

bpo-44991: Normalise sqlite3 function and collation callback naming#28209

Merged
encukou merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-normalise-func
Oct 12, 2021
Merged

bpo-44991: Normalise sqlite3 function and collation callback naming#28209
encukou merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-normalise-func

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Sep 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

I forgot these two in GH-28088.

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

cc. @encukou

@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise function and collation callback naming Sep 7, 2021
@erlend-aasland erlend-aasland reopened this Sep 7, 2021
@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

Reopening to trigger asan test again.

shihai1991
shihai1991 approved these changes Sep 7, 2021
View reviewed changes

@shihai1991 shihai1991 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Keeping consistent code style is fine to me.

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

Keeping consistent code style is fine to me.

Thanks for reviewing!

@github-actions

github-actions Bot commented Oct 8, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
encukou
encukou reviewed Oct 12, 2021
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I don't care that strongly about the pysqlite prefix, so I didn't point this out in the earlier review.
But sure, let's make them consistent!

@encukou encukou merged commit cfb1df3 into python:main Oct 12, 2021
@erlend-aasland erlend-aasland deleted the sqlite-normalise-func branch October 12, 2021 11:39
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@shihai1991 shihai1991 shihai1991 approved these changes

@berkerpeksag berkerpeksag

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @encukou @shihai1991 @the-knights-who-say-ni @bedevere-bot