bpo-30940: fix docs for round if second arg is None#2824
Conversation
|
@daxlab, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @rhettinger to be potential reviewers. |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Needed to update the docstring too.
The signature of the function can be written as
round(number, ndigits=None)
Sorry, something went wrong.
mdickinson
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this!
Sorry, something went wrong.
|
Please update the docstring. And what is more correct, (as in the first paragraph), or (as in the second paragraph)? Or both are correct? |
Sorry, something went wrong.
|
|
Sorry, something went wrong.
|
About
versus
I think either is fine. To my eyes, the first looks a bit clearer, but also a bit more pedantic. |
Sorry, something went wrong.
|
@serhiy-storchaka plz review. Also, should I send a separate PR to 3.6 branch or you can cherry-pick ? |
Sorry, something went wrong.
|
The current changes LGTM, but see a discussion on the tracker. Perhaps the documentation needs additional clarification. |
Sorry, something went wrong.
https://bugs.python.org/issue30940