◐ Shell
reader mode source ↗
Skip to content

bpo-5846: Do not use obsolete unittest functions.#28303

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:unittest-makesuite
Sep 13, 2021
Merged

bpo-5846: Do not use obsolete unittest functions.#28303
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:unittest-makesuite

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 13, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.

https://bugs.python.org/issue5846

erlend-aasland
erlend-aasland requested changes Sep 13, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please use defaultTestLoader instead of creating a new instance whenever possible.

@serhiy-storchaka
bpo-5846: Do not use obsolete unittest functions. …
af2f55f 
Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.
@serhiy-storchaka serhiy-storchaka merged commit 851811f into python:main Sep 13, 2021
@serhiy-storchaka serhiy-storchaka deleted the unittest-makesuite branch September 13, 2021 07:49
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Sep 13, 2021
Merge branch 'main' into fix-issue-5846 …
db40a08 
Sync with main bco. python#28303
@voidspace voidspace mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@brettcannon brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @erlend-aasland @the-knights-who-say-ni @bedevere-bot